Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#38608 closed update (fixed)

apache-ant: update to 1.9

Reported by: ses@… Owned by: blair (Blair Zajac)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: apache-ant

Description

Port: dports/devel/apache-ant

The prior upgrade to use the right java_home causes ant to lose with openjdk 1.8.

This is a problem with ant 1.8.*, but is fixed in Ant 1.9.

So easy fix: update the port to use ant 1.9.

git diff -p attached:

Attachments (1)

ant-diffs (1.2 KB) - added by ses@… 11 years ago.
patch to switch to apache ant 1.9.0

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by ses@…

Attachment: ant-diffs added

patch to switch to apache ant 1.9.0

comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)

try attaching it as a .diff file to see if that will get Trac to do the proper highlighting for it

comment:2 in reply to:  1 ; Changed 11 years ago by larryv (Lawrence Velázquez)

Keywords: haspatch added
Owner: changed from macports-tickets@… to blair@…
Port: apache-ant added
Summary: apache-ant is not at 1.9 - breaks with openjdk 8apache-ant: update to 1.9

In the future, please Cc relevant port maintainers.

Replying to egall@…:

try attaching it as a .diff file to see if that will get Trac to do the proper highlighting for it

We can read raw diffs, thanks.

comment:3 Changed 11 years ago by blair (Blair Zajac)

Resolution: fixed
Status: newclosed

Thanks, fixed in r104691.

Couple of points for your next patch:

  • Move revision back to 0 on an upgrade.
  • Use upstream's checksums, in this case md5 and sha1, since it's easier to verify that the Portfile is correct.

comment:4 in reply to:  2 Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to larryv@…:>

Replying to egall@…:

try attaching it as a .diff file to see if that will get Trac to do the proper highlighting for it

We can read raw diffs, thanks.

But pretty colors though! :-(

Note: See TracTickets for help on using tickets.