Opened 11 years ago

Closed 11 years ago

#38678 closed defect (fixed)

xdelta1 @ 1.1.4 Fix aclocal warning caused by underquoted definition in xdelta.m4

Reported by: maehne (Torsten Maehne) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch maintainer Cc: cooljeanius (Eric Gallager)
Port: xdelta1

Description

The xdelta.m4 file installed by the xdelta1 port to /opt/local/share/aclocal/ causes an annoying warning each time aclocal is run:

/opt/local/share/aclocal/xdelta.m4:7: warning: underquoted definition of AM_PATH_XDELTA
/opt/local/share/aclocal/xdelta.m4:7:   run info Automake 'Extending aclocal'
/opt/local/share/aclocal/xdelta.m4:7:   or see http://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal

The fix is described in https://bugs.archlinux.org/task/20895 but won't probably applied upstream, as xdelta 1.1.4 is an old stable maintenance release superseded by Xdelta-3.0. I attach a patch updating the Portfile and including the patch.

Could some maintainer with commit rights to the repository please apply the patch?

Attachments (1)

patch-xdelta1-aclocal_warning_on_xdelta.m4.diff (1.2 KB) - added by maehne (Torsten Maehne) 11 years ago.
Patch for xdelta1 to fix the aclocal warning caused by xdelta.m4

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by maehne (Torsten Maehne)

Patch for xdelta1 to fix the aclocal warning caused by xdelta.m4

comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:2 Changed 11 years ago by maehne (Torsten Maehne)

The error and patch has been reported upstream already in December 2007:

http://code.google.com/p/xdelta/issues/detail?id=49

It has not been integrated into a new maintenance release.

comment:3 Changed 11 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Sorry for the (excessive) delay, committed in r110686. If a patch takes that long to commit again, consider dropping a mail to the macports-dev list.

Note: See TracTickets for help on using tickets.