Opened 11 years ago

Closed 8 years ago

#39033 closed defect (fixed)

gtkimageview: fix compiling with -Werror by default

Reported by: Ionic (Mihai Moldovan) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: gtkimageview

Description

Currently usage of -Werror is forced by the configure script, no matter what the user decides to set via the --enable-compile-warnings toggle. Fix that.

Attachments (2)

portfile.diff (703 bytes) - added by Ionic (Mihai Moldovan) 11 years ago.
Use the configure switch, use patch.
patch-configure.diff (1.1 KB) - added by Ionic (Mihai Moldovan) 11 years ago.
Don't unconditionally use -Werror.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by Ionic (Mihai Moldovan)

Attachment: portfile.diff added

Use the configure switch, use patch.

Changed 11 years ago by Ionic (Mihai Moldovan)

Attachment: patch-configure.diff added

Don't unconditionally use -Werror.

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: devans openmaintainer removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to devans@…
Summary: Fix gtkimageview compiling with -Werror by defaultgtkimageview: fix compiling with -Werror by default
Type: submissiondefect

The Cc field requires full email addresses. openmaintainer and nomaintainer are symbolic and are not addresses that go anywhere.

comment:2 Changed 11 years ago by larryv (Lawrence Velázquez)

Have you reported this upstream?

comment:3 Changed 11 years ago by Ionic (Mihai Moldovan)

Nope, not yet. Thanks.

comment:4 Changed 11 years ago by Ionic (Mihai Moldovan)

Reporting upstream doesn't really work, as upstream is not accepting new bug reports via trac, cf. http://bjourne.webfactional.com/

I sent the developer a mail, but don't expect a lot, as the project hasn't seen updates for three years.

comment:5 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

This appears to have been committed some time ago - it builds fine

Note: See TracTickets for help on using tickets.