Opened 8 years ago

Last modified 7 years ago

#39182 assigned enhancement

MacVim @7.3.snapshot66_3: should use vim's vimfiles directory

Reported by: larryv (Lawrence Velázquez) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: g5pw (Aljaž Srebrnič), cooljeanius (Eric Gallager)
Port: MacVim

Description

A number of ports install Vim support files into ${prefix}/share/vim/vimfiles. MacVim currently doesn’t pick these up.

The attached patch corrects this by adding the vim port’s vimfiles directory to MacVim’s default runtimepath.

Another option would be to create a symlink at ${applications_dir}/MacVim.app/Contents/Resources/vim/vimfiles pointing to ${prefix}/share/vim/vimfiles, but that feels a little sneaky to me. It would admittedly be a little simpler.

Attachments (1)

fix-MacVim-runtimepath.diff (2.3 KB) - added by larryv (Lawrence Velázquez) 8 years ago.
patch to change MacVim's default runtimepath

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by larryv (Lawrence Velázquez)

Attachment: fix-MacVim-runtimepath.diff added

patch to change MacVim's default runtimepath

comment:1 Changed 8 years ago by raimue (Rainer Müller)

Status: newassigned

Hm, I think the symlink solution would be okay as well. Due to the linking with libraries from ports and hardcoded paths to binaries the resulting MacVim.app is not portable anyway.

Last edited 8 years ago by raimue (Rainer Müller) (previous) (diff)

comment:2 in reply to:  1 Changed 8 years ago by larryv (Lawrence Velázquez)

I don’t feel particularly strongly one way or the other.

On the one hand, tweaking runtimepath is mildly more transparent about where the added runtime files are coming from, and it ensures that the MacPorts vimfiles directories are always searched, even if the user changes $VIM. (This could just as easily be considered a drawback.)

On the other, it is additional code that would have to be maintained.

comment:3 Changed 8 years ago by g5pw (Aljaž Srebrnič)

Well, the link solution surely is easier, I'd say let the maintainer decide. :)

comment:4 Changed 8 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:5 Changed 7 years ago by raimue (Rainer Müller)

Another point that came to mind, what would happen if the vimfiles directory does not exist yet? Should we just put a dummy file there to silence any warnings? However, I still have not tested this yet.

Note: See TracTickets for help on using tickets.