Opened 11 years ago
Closed 11 years ago
#39453 closed update (fixed)
py-flask: update to 0.10.1
| Reported by: | lpsinger (Leo Singer) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | py-flask |
Description
Flask 0.10.1 is available. The attached diff updates py-flask, bringing in a new dependency on itsdangerous. A Portfile for itsdangerous is also attached.
I also added setuptools as a build dependency.
Attachments (2)
Change History (5)
Changed 11 years ago by lpsinger (Leo Singer)
| Attachment: | patch-Portfile.diff added |
|---|
Changed 11 years ago by lpsinger (Leo Singer)
new Portfile for py-itsdangerous
comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)
| Owner: | changed from ryandesign to ryandesign@… |
|---|---|
| Version: | 2.1.3 |
comment:2 follow-up: 3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
I updated py-flask to 0.10.1 in r107088 before seeing this ticket.
py-flask 0.10 and greater require Python 2.6 or 2.7 so the py25-flask subport remains at version 0.9.
The request to add the setuptools dependency is #38892 however the buildbot installed it just fine without that. py-flask already declares a library dependency on py-jinja2 which declares a library dependency on py-setuptools so it should not be possible for a user to not already have setuptools installed. But I have no objection to adding the dependency to be explicit about it.
I did not add the itsdangerous dependency because I didn't know about it. Feel free to add that port and then add it to the py-flask dependencies and increase the revision. Since itsdangerous doesn't appear to be used by py25-flask @0.9, the dependency should not be added to py25-flask and its revision should not be increased.
comment:3 Changed 11 years ago by lpsinger (Leo Singer)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to ryandesign@…:
I updated py-flask to 0.10.1 in r107088 before seeing this ticket.
py-flask 0.10 and greater require Python 2.6 or 2.7 so the py25-flask subport remains at version 0.9.
The request to add the setuptools dependency is #38892 however the buildbot installed it just fine without that. py-flask already declares a library dependency on py-jinja2 which declares a library dependency on py-setuptools so it should not be possible for a user to not already have setuptools installed. But I have no objection to adding the dependency to be explicit about it.
I did not add the itsdangerous dependency because I didn't know about it. Feel free to add that port and then add it to the py-flask dependencies and increase the revision. Since itsdangerous doesn't appear to be used by py25-flask @0.9, the dependency should not be added to py25-flask and its revision should not be increased.
Thank you. The itsdangerous dependency is added in r107098.
patch for py-flask's Portfile