Opened 11 years ago
Closed 11 years ago
#39732 closed enhancement (fixed)
pymol @1.5_7: Add to chemistry category
| Reported by: | c.herbig@… | Owned by: | howarth@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | cooljeanius (Eric Gallager) |
| Port: | pymol |
Description
Append chemistry to keywords so that it will show up in the chemistry category.
Attachments (1)
Change History (8)
Changed 11 years ago by c.herbig@…
| Attachment: | Portfile-pymol.diff added |
|---|
comment:1 follow-up: 2 Changed 11 years ago by larryv (Lawrence Velázquez)
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
comment:2 follow-up: 3 Changed 11 years ago by c.herbig@…
Replying to larryv@…:
There really shouldn’t be a “chemistry” category, since there would be only 3 ports in it after committing this patch. Removed in r108165.
I’ve submitted about 10 patches today to add chemistry to the categories, so there ought to be a dozen or so in the chemistry category. However, by your reasoning, there shouldn’t be a ‘chinese’, ‘russian’ or ‘ipv6’ category either, yet there they are. It fact there are many categories that only expose a few ports. It seems to me that the entire purpose of categories was to increase discoverability…
comment:3 follow-up: 5 Changed 11 years ago by larryv (Lawrence Velázquez)
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
Replying to c.herbig@…:
I’ve submitted about 10 patches today to add chemistry to the categories, so there ought to be a dozen or so in the chemistry category.
I actually just noticed those. Entirely my fault. Restored in r108167.
However, by your reasoning, there shouldn’t be a ‘chinese’, ‘russian’ or ‘ipv6’ category either, yet there they are. It fact there are many categories that only expose a few ports.
It’s been generally accepted that categories containing only a few ports should be removed.
comment:4 Changed 11 years ago by larryv (Lawrence Velázquez)
| Cc: | howarth@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to howarth@… |
| Status: | reopened → new |
| Summary: | Add chemistry keyword to pymol portfile → pymol @1.5_7: Add to chemistry category |
comment:5 Changed 11 years ago by c.herbig@…
Replying to larryv@…:
Replying to c.herbig@…:
I’ve submitted about 10 patches today to add chemistry to the categories, so there ought to be a dozen or so in the chemistry category.
I actually just noticed those. Entirely my fault. Restored in r108167.
However, by your reasoning, there shouldn’t be a ‘chinese’, ‘russian’ or ‘ipv6’ category either, yet there they are. It fact there are many categories that only expose a few ports.
It’s been generally accepted that categories containing only a few ports should be removed.
Seems sensible, and the whole point of my submitting these patches was to create a chemistry category worth having.
Thank you for reconsidering this case.
comment:7 Changed 11 years ago by larryv (Lawrence Velázquez)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Maintainer timeout, r109590.
There really shouldn’t be a “chemistry” category, since there would be only 3 ports in it after committing this patch. Removed in r108165.