libgit2: update to 0.19.0

[nvenegas@…]

Changes between 0.17.0 and 0.19.0 are list at ​https://github.com/libgit2/libgit2/releases

[ryandesign (Ryan Carsten Schmidt)]

What's "github.tarball_from archive"? The only valid values for github.tarball_from are "downloads" and "tags".

[nvenegas@…]

Ah, good question: I couldn't find documentation on the "github.tarball_from" property, but when I tried "downloads" it 404'd when fetching 0.19.0. Looking at the URL it tried to download from, I noticed that ​https://github.com/libgit2/libgit2/releases links to ​https://github.com/libgit2/libgit2/archive/v0.19.0.tar.gz so I thought "archive" would be another valid value.

It seemed to work, but now when I try my Portfile (using "archive") it fetches a binary from ​http://mse.uk.packages.macports.org/sites/packages.macports.org/libgit2

[larryv (Lawrence Velázquez)]

Replying to nvenegas@…:

It seemed to work, but now when I try my Portfile (using "archive") it fetches a binary from ​http://mse.uk.packages.macports.org/sites/packages.macports.org/libgit2

Use port -s to force a build from source.

[nvenegas@…]

With "archive" it fetched from "​https://github.com/libgit2/libgit2/tarball/v0.19.0".

With "tags" it also fetched from "​https://github.com/libgit2/libgit2/tarball/v0.19.0".

I guess I hit the fall through logic with "archive". I'll update the attached patch.

[tomasz.elendt@…]

Is there anything missing? The attached fix works for me.

[dbevans (David B. Evans)]

Updated to version 0.20.0 in r115002.