Opened 11 years ago

Closed 11 years ago

#40117 closed update (fixed)

collada-dom: update to 2.4

Reported by: kyle.j.kauffman@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: collada-dom

Description

Update to collada-dom port from 2.2->2.4. Current port is 2.2 and is broken (see #36416). 2.2 also has an outdated API that breaks some software.

Attachments (3)

Portfile​ (1.1 KB) - added by kyle.j.kauffman@… 11 years ago.
New 2.4 portfile.
patch-CMakeLists.txt.diff​ (505 bytes) - added by kyle.j.kauffman@… 11 years ago.
Patch to stop collada-dom from trying to use 64-bit symbols not present on OS X.
Portfile-collada-dom.diff​ (3.5 KB) - added by kyle.j.kauffman@… 11 years ago.
Modified Portfile diff after comments.

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by kyle.j.kauffman@…

Attachment: Portfile​ added

New 2.4 portfile.

Changed 11 years ago by kyle.j.kauffman@…

Attachment: patch-CMakeLists.txt.diff​ added

Patch to stop collada-dom from trying to use 64-bit symbols not present on OS X.

comment:1 in reply to:  description Changed 11 years ago by larryv (Lawrence Velázquez)

Keywords: collada-dom removed
Summary: Update collada-dom to 2.4 (current port broken anyway) → collada-dom @@2.2_1: update to 2.4
Version: 2.2.0

​As per the Guide, please attach a ​unified diff of the Portfile instead of the whole Portfile.

comment:2 Changed 11 years ago by kyle.j.kauffman@…

Sure thing, added diff file.

comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Keywords: haspatch added

Thanks. I had previously tried to update the port to version 2.3.1 but did not commit it; I forget why. Some observations about your proposal:

  • The revision should drop to 0 when the version is increased.
  • The master_sites should be rewritten to avoid redirects.
  • cmake is likely only a build dependency, not a library dependency.
  • Since this uses cmake, consider using the cmake portgroup which takes care of a lot of things for you, including adding the cmake build depedency and setting the CMAKE_INSTALL_PREFIX.

Changed 11 years ago by kyle.j.kauffman@…

Attachment: Portfile-collada-dom.diff​ added

Modified Portfile diff after comments.

comment:4 Changed 11 years ago by kyle.j.kauffman@…

Sounds good, I've incorporated all those comments into the unified diff.

comment:5 Changed 11 years ago by cooljeanius (Eric Gallager)

I would like to see this update pushed through, as collada-dom is currently the port that my rev-upgrade is choking on...

comment:6 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:7 in reply to:  5 Changed 11 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

I would like to see this update pushed through

So ask macports-dev.

comment:8 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: new → assigned
Summary: collada-dom @@2.2_1: update to 2.4 → collada-dom: update to 2.4

comment:9 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: assigned → closed

r111739

Note: See TracTickets for help on using tickets.