Opened 7 years ago

Closed 7 years ago

#40218 closed submission (fixed)

new port uftp

Reported by: fclaire@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: uftp3

Description

Please find attached a Portfile and patch for the software uftp.

Thanks for checking and committing.

Attachments (3)

Portfile (2.3 KB) - added by fclaire@… 7 years ago.
patch-makefile.diff (1.2 KB) - added by fclaire@… 7 years ago.
Portfile.2 (2.4 KB) - added by fclaire@… 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by fclaire@…

Attachment: Portfile added

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Thanks. Some observations:

  • Variants whose names begin with "no_" are deprecated and should not be added to new ports. Use a positively-named variant instead and enable it by default.
  • Since you used "use_configure no", you're responsible for UsingTheRightCompiler and -arch flags and if possible adding a universal variant.

comment:2 Changed 7 years ago by fclaire@…

Hi Ryan,

Thanks for checking. Indeed I'll use a positively-named variant and will submit a new Portfile soon.

For UsingTheRightCompiler the original makefile forces $CC to gcc by default. So it seems it's the uftp author's intention to get this software compiled with gcc and not with another compiler. So I'll patch the makefile and set gcc as the compiler in the Portfile.

Changed 7 years ago by fclaire@…

Attachment: patch-makefile.diff added

Changed 7 years ago by fclaire@…

Attachment: Portfile.2 added

comment:3 Changed 7 years ago by fclaire@…

Please find attached a new Portfile (forgot to tick the box to delete the old one) and a new patch file for makefile.

comment:4 Changed 7 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: newassigned
Version: 2.2.0

comment:5 Changed 7 years ago by larryv (Lawrence Velázquez)

Is there some reason you specified an old version?

comment:6 in reply to:  5 Changed 7 years ago by larryv (Lawrence Velázquez)

Replying to larryv@…:

Is there some reason you specified an old version?

Never mind, found your thread post after encountering the same issue.

comment:7 Changed 7 years ago by larryv (Lawrence Velázquez)

Port: uftp3 added; uftp removed
Resolution: fixed
Status: assignedclosed

Created uftp3 in r110030:110031 with universal variant.

Note: See TracTickets for help on using tickets.