Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#40489 closed defect (fixed)

libcipher fails to compile on Mountain Lion

Reported by: casner@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: haspatch Cc:
Port: libcipher

Description

The newer compilers are more picky about type conflicts and lvalue operations, so this port fails to compile on Mountain Lion. Log, patch and updated Portfile attached.

Attachments (3)

libcipher.log (22.2 KB) - added by casner@… 4 years ago.
Error log
patch-crypt.c (769 bytes) - added by casner@… 4 years ago.
Patch to correct the compilation errors
Portfile (1.5 KB) - added by casner@… 4 years ago.
Updated Portfile to include the additional patch

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by casner@…

Error log

Changed 4 years ago by casner@…

Patch to correct the compilation errors

Changed 4 years ago by casner@…

Updated Portfile to include the additional patch

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

  • Keywords haspatch added
  • Owner changed from macports-tickets@… to ryandesign@…
  • Port libcipher added
  • Status changed from new to assigned

Thanks. This probably has more to do with the Xcode version (more specifically the clang version) than the OS X version. Users with the latest Xcode on Lion would probably see this problem too.

comment:2 follow-up: Changed 4 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed in r111145. For future reference, we prefer a unified diff of the portfile, rather than an entire new portfile, so that it's easier to evaluate your changes without needing to download and diff the portfile ourselves.

comment:3 in reply to: ↑ 2 Changed 4 years ago by casner@…

Replying to ryandesign@…:

Committed in r111145. For future reference, we prefer a unified diff of the portfile, rather than an entire new portfile, so that it's easier to evaluate your changes without needing to download and diff the portfile ourselves.

Sorry, I was trying to follow the MapPorts Guide, but I did not read 7.2.2 carefully enough. I see now that refers to details in 4.5.1.

Thanks for picking up the fix quickly.

Note: See TracTickets for help on using tickets.