Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#40675 closed submission (fixed)

jsoncpp @0.6.0-rc2 - Request to include port (portfile attached)

Reported by: felipou (Felipe Machado) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: jsoncpp

Description

I created a Portfile for the jsoncpp library (http://jsoncpp.sourceforge.net/).

I think it's an interesting port to add.

Also, feedback would be much appreciated, it's my first Portfile and using a build system (scons) that I'm not used to.

Thanks, Felipe

Attachments (1)

jsoncpp.tar.gz (1.3 KB) - added by felipou (Felipe Machado) 11 years ago.
jsoncpp port

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by felipou (Felipe Machado)

Attachment: jsoncpp.tar.gz added

jsoncpp port

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: json removed
Owner: changed from macports-tickets@… to ryandesign@…
Port: jsoncpp added
Status: newassigned

Thanks; the portfile looks pretty good, except that because you are not a committer the maintainers line should be your full email address in our obfuscated host:user format.

Also for future reference please just attach the files themselves instead of putting them in an archive, so they can be viewed without downloading.

comment:2 in reply to:  1 Changed 11 years ago by felipou (Felipe Machado)

Wow, that was fast :)

Thanks for the feedback! Should I change the file (add my email) and reattach it?

comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

And the license field should just read MIT.

I already had the json-c port installed, which also installs a file /opt/local/include/json/json.h. So I'll mark the two port as conflicting with one another.

Committed the port with changes in r111881 and marked json-c conflicting in r111882.

comment:4 in reply to:  3 Changed 11 years ago by felipou (Felipe Machado)

I just checked the ubuntu package for this library, and it puts all the includes in a "jsoncpp" folder inside "/usr/include": http://packages.ubuntu.com/precise/amd64/libjsoncpp-dev/filelist

Maybe the macports version should do the same, to improve portability?

comment:5 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

We could do that. If that's desired, please file a new ticket. However, if that's where the software should be installed, you'd think the developers would configure their build system to put it there.

Note: See TracTickets for help on using tickets.