Opened 11 years ago

Closed 11 years ago

#40869 closed defect (fixed)

makeicns: undefined type CGDirectPaletteRef on 10.9

Reported by: nerdling (Jeremy Lavergne) Owned by: mkae (Marko Käning)
Priority: Normal Milestone:
Component: ports Version: 2.2.99
Keywords: mavericks Cc: pixilla (Bradley Giesbrecht), ryandesign (Ryan Carsten Schmidt), disposable@…, kenyon@…, macports@…, valorisa, carmine.ventre@…, laew_rena24@…, valentin@…, Schamschula (Marius Schamschula), mathsmac@…, m@…
Port: makeicns

Description (last modified by mf2k (Frank Schima))

10.9 with Xcode 5.0.1 and the new Command Line Tools.

IconFamily.m:1364
error: use of undeclared identifier 'CGDirectPaletteRef'

Attachments (1)

patch-makeicns.diff (2.7 KB) - added by pguyot (Paul Guyot) 11 years ago.
Do not create ics8 and icl8 on 10.9, thus fixing incompatibility.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

Cc Me!

comment:3 Changed 11 years ago by disposable@…

Cc: disposable@… added

Cc Me!

comment:4 in reply to:  description ; Changed 11 years ago by macports@…

Unless I'm mistaken the relevant error is:

:debug:build couldn't open "/System/Library/Frameworks/Tcl.framework/Versions/8.5/Resources/tclIndex": no such file or directory

Sure enough:

$ ll /System/Library/Frameworks/Tcl.framework/Versions/8.5/Resources/
total 0
drwxr-xr-x   3 root  wheel   102B Oct 16 20:54 BridgeSupport
drwxr-xr-x   3 root  wheel   102B Aug 24 22:34 Documentation
-rw-r--r--   1 root  wheel   1.2K Oct 23 10:59 Info.plist
drwxr-xr-x  18 root  wheel   612B Aug 24 22:33 Scripts
-rw-r--r--   1 root  wheel   2.2K Oct 23 10:59 license.terms
drwxr-xr-x   4 root  wheel   136B Aug 24 22:56 tcl8
-rw-r--r--   1 root  wheel   456B Aug 24 23:46 version.plist

I imagine this is something that was changed with Mavericks.

comment:5 in reply to:  4 Changed 11 years ago by nerdling (Jeremy Lavergne)

Replying to macports@…:

That's unrelated and occurs on pretty much all systems.

comment:6 Changed 11 years ago by kenyon@…

Cc: kenyon@… added

Cc Me!

comment:7 in reply to:  4 ; Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: macports@… added

Replying to macports@…:

Unless I'm mistaken the relevant error is:

:debug:build couldn't open "/System/Library/Frameworks/Tcl.framework/Versions/8.5/Resources/tclIndex": no such file or directory

You are mistaken; see #37231.

comment:8 in reply to:  7 Changed 11 years ago by macports@…

Replying to ryandesign@…:

You are mistaken; see #37231.

Thank you.

comment:9 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: bbrodeau@… added

Has duplicate #41016.

comment:10 Changed 11 years ago by carmine.ventre@…

Cc: carmine.ventre@… added

Cc Me!

Changed 11 years ago by pguyot (Paul Guyot)

Attachment: patch-makeicns.diff added

Do not create ics8 and icl8 on 10.9, thus fixing incompatibility.

comment:11 Changed 11 years ago by pguyot (Paul Guyot)

The bug doesn't seem to be fixed upstream.

makeicns relied on CGPaletteCreateDefaultColorPalette to create ics8 and icl8 icons using Mac's traditional 8 bit color palette. This API is no longer available in 10.9.

Two solutions exist: avoid creating the ics8 and icl8 icons (cf patch above) or re-implement the sampling from 24 bit RGB to 8 bit indexed colors (the easiest being to do 6 bit RGB, although quality will be inferior than what was available in 10.8).

comment:12 Changed 11 years ago by mkae (Marko Käning)

I'll update the sources by integrating the patch. Thanks!

comment:13 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: laew_rena24@… added

Has duplicate #41083.

comment:14 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: valentin@… added

Has duplicate #41127.

comment:15 Changed 11 years ago by Schamschula (Marius Schamschula)

Cc: mschamschula@… added

Cc Me!

comment:16 Changed 11 years ago by mathsmac@…

Cc: mathsmac@… added

Cc Me!

comment:17 Changed 11 years ago by m@…

Cc: m@… added

Cc Me!

comment:18 Changed 11 years ago by m@…

Hey Guys,

I want to instal Bacula on osx 10.9 but i think i have the same isseu. How does the patching work? I could do it oon my own i read but when is this patch done in the repository?

comment:19 Changed 11 years ago by mkae (Marko Käning)

I'll take care of it just now. Please stay patient.

comment:20 Changed 11 years ago by m@…

I'm staying patient!!!!! :) Sorry to ask but how can i see the patch is done? And must i do a upgrade on anything? so yes how? (i'm newby at macPorts but i love it so far!)

Last edited 11 years ago by m@… (previous) (diff)

comment:21 Changed 11 years ago by mkae (Marko Käning)

I've included this patch for now as is in the port by r113008.

I'll update the sources later also.

Thanks for supplying the patch.

comment:22 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.