Opened 11 years ago

Closed 11 years ago

#40942 closed defect (fixed)

gaw requires gtk2 +x11

Reported by: nerdling (Jeremy Lavergne) Owned by: maehne (Torsten Maehne)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: gaw

Description

Gaw should use the active_variants PortGroup to ensure that gtk2 +x11 is installed. This is required for the gdk/gdkx.h file.

Attachments (2)

patch-gaw-portfile-gtk2-x11-variant.diff (594 bytes) - added by maehne (Torsten Maehne) 11 years ago.
fix-ws-gaw-Portfile.diff (3.2 KB) - added by maehne (Torsten Maehne) 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by maehne (Torsten Maehne)

Changed 11 years ago by maehne (Torsten Maehne)

Attachment: fix-ws-gaw-Portfile.diff added

comment:1 Changed 11 years ago by maehne (Torsten Maehne)

Thanks for reporting this issue. The uploaded patch file patch-gaw-portfile-gtk2-x11-variant.diff should resolve this issue. I did not pump up the revision number, as only new installations are affected by the problem. Could you please have look if I used the active_variants PortGroup correctly? It's the first time I had to use it. On my side, I was able to compile and install gaw without any problem linking against the already installed gtk2 +x11 port. I am not able to test it against a gtk2 +quartz variant, as it would break to many other ports on my system.

The second patch fix-ws-gaw-Portfile.diff adjusts the whitespaces in the Portfile due to the added require_active_variants statement.

Could someone with commit rights please approve these changes and commit them to the SVN?

comment:2 Changed 11 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: newclosed

Patched in r112696 and r112697.

Here's the output of attempting to install gaw without gtk2's +x11:

--->  Computing dependencies for gaw
--->  Fetching distfiles for gaw
--->  Verifying checksums for gaw
--->  Extracting gaw
--->  Applying patches to gaw
--->  Configuring gaw
Error: org.macports.configure for port gaw returned: gtk2 must be installed with +x11.
Note: See TracTickets for help on using tickets.