#41140 closed defect (fixed)
valgrind @3.9.0 fails to build on OS X 10.6.8
| Reported by: | mopihopi | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | Cc: | florian@…, gnw3, mkae (Marko Käning), eborisch (Eric A. Borisch), someuser12, wojdyr@…, cooljeanius (Eric Gallager) | |
| Port: | valgrind |
Description
valgrind @3.9.0 fails to build on OS X 10.6.8:
$ sudo port upgrade valgrind
---> Computing dependencies for valgrind
---> Fetching archive for valgrind
---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://packages.macports.org/valgrind
---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/valgrind
---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://lil.fr.packages.macports.org/valgrind
---> Fetching distfiles for valgrind
---> Verifying checksums for valgrind
---> Extracting valgrind
---> Applying patches to valgrind
---> Configuring valgrind
---> Building valgrind
Error: org.macports.build for port valgrind returned: command execution failed
Please see the log file for port valgrind for details:
/opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_devel_valgrind/valgrind/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
http://guide.macports.org/#project.tickets
Attachments (5)
Change History (23)
Changed 10 years ago by mopihopi
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | raimue@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to raimue@… |
comment:2 Changed 10 years ago by raimue (Rainer Müller)
Changed 10 years ago by florian@…
| Attachment: | syswrap-darwin.c.diff added |
|---|
Changed 10 years ago by raimue (Rainer Müller)
| Attachment: | patch-syswrap-snowleopard.diff added |
|---|
comment:5 Changed 10 years ago by raimue (Rainer Müller)
Your workaround seems a bit crude and would probably not be accepted upstream. Judging from what you did, I created an untested patch which is supposed to be more correct. Can you please test the attached patch on Snow Leopard?
comment:6 Changed 10 years ago by florian@…
Actually my proposed patch just reinstates the conditions in syswrap-darwin.c of version 3.8.1. The #if DARWIN_VERS >= DARWIN_10_7 [...] #endif was absent there. So we don't know whether this is an upstream glitch or intention. From the comments in syswrap-darwin.c I would judge the former. Your patch (which works fine as well) will probably be the desired upstream solution. Pls go ahead and commit.
comment:7 Changed 10 years ago by mopihopi
10.6 actually does have psynch_mutexwait, psynch_mutexdrop, psynch_cvbroad, psynch_cvsignal, psynch_cvwait, psynch_rw_rdlock, psynch_rw_wrlock, and psynch_rw_unlock. However psynch_cvclrprepost was added in 10.7.
comment:8 Changed 10 years ago by florian@…
Well then again it would be better to have an intermediate solution.
comment:13 follow-up: 16 Changed 10 years ago by mopihopi
The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue.
Changed 10 years ago by cooljeanius (Eric Gallager)
| Attachment: | valgrind-osx-106-327745.patch added |
|---|
patch from upstream bug report
comment:16 Changed 10 years ago by cooljeanius (Eric Gallager)
Replying to mopihopi@…:
The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue.
I re-attached it here for easier review. Could someone commit it please? (I am running into this issue, as well, which is preventing me from testing one of my other Portfiles that I am developing...)
comment:17 follow-up: 18 Changed 10 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r117639.
I guess from the build error this would also fail outside of MacPorts. Please report this problem upstream.
Furthermore, Mac OS X 10.6 Snow Leopard is a system with legacy support only in MacPorts. I would happily accept a patch for the valgrind port that fixes this problem, but I won't work on it myself (as I also don't have an installation of this OS release anymore).