Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#41140 closed defect (fixed)

valgrind @3.9.0 fails to build on OS X 10.6.8

Reported by: mopihopi Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: florian@…, gnw3, mkae (Marko Käning), eborisch (Eric A. Borisch), someuser12, wojdyr@…, cooljeanius (Eric Gallager)
Port: valgrind

Description

valgrind @3.9.0 fails to build on OS X 10.6.8:

$ sudo port upgrade valgrind
--->  Computing dependencies for valgrind
--->  Fetching archive for valgrind
--->  Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://packages.macports.org/valgrind
--->  Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/valgrind
--->  Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://lil.fr.packages.macports.org/valgrind
--->  Fetching distfiles for valgrind
--->  Verifying checksums for valgrind
--->  Extracting valgrind
--->  Applying patches to valgrind
--->  Configuring valgrind
--->  Building valgrind
Error: org.macports.build for port valgrind returned: command execution failed
Please see the log file for port valgrind for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_devel_valgrind/valgrind/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets

Attachments (5)

main.log (241.2 KB) - added by mopihopi 7 years ago.
Portfile.diff (433 bytes) - added by florian@… 7 years ago.
Portfile patch
syswrap-darwin.c.diff (622 bytes) - added by florian@… 7 years ago.
patch-syswrap-snowleopard.diff (1.2 KB) - added by raimue (Rainer Müller) 7 years ago.
valgrind-osx-106-327745.patch (14.5 KB) - added by cooljeanius (Eric Gallager) 7 years ago.
patch from upstream bug report

Download all attachments as: .zip

Change History (23)

Changed 7 years ago by mopihopi

Attachment: main.log added

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: raimue@… removed
Owner: changed from macports-tickets@… to raimue@…

comment:2 Changed 7 years ago by raimue (Rainer Müller)

I guess from the build error this would also fail outside of MacPorts. Please report this problem upstream.

Furthermore, Mac OS X 10.6 Snow Leopard is a system with legacy support only in MacPorts. I would happily accept a patch for the valgrind port that fixes this problem, but I won't work on it myself (as I also don't have an installation of this OS release anymore).

Changed 7 years ago by florian@…

Attachment: Portfile.diff added

Portfile patch

Changed 7 years ago by florian@…

Attachment: syswrap-darwin.c.diff added

comment:3 Changed 7 years ago by florian@…

Cc: florian@… added

Cc Me!

comment:4 Changed 7 years ago by florian@…

I attached a workaround.

Changed 7 years ago by raimue (Rainer Müller)

comment:5 Changed 7 years ago by raimue (Rainer Müller)

Your workaround seems a bit crude and would probably not be accepted upstream. Judging from what you did, I created an untested patch which is supposed to be more correct. Can you please test the attached patch on Snow Leopard?

comment:6 Changed 7 years ago by florian@…

Actually my proposed patch just reinstates the conditions in syswrap-darwin.c of version 3.8.1. The #if DARWIN_VERS >= DARWIN_10_7 [...] #endif was absent there. So we don't know whether this is an upstream glitch or intention. From the comments in syswrap-darwin.c I would judge the former. Your patch (which works fine as well) will probably be the desired upstream solution. Pls go ahead and commit.

comment:7 Changed 7 years ago by mopihopi

10.6 actually does have psynch_mutexwait, psynch_mutexdrop, psynch_cvbroad, psynch_cvsignal, psynch_cvwait, psynch_rw_rdlock, psynch_rw_wrlock, and psynch_rw_unlock. However psynch_cvclrprepost was added in 10.7.

comment:8 Changed 7 years ago by florian@…

Well then again it would be better to have an intermediate solution.

comment:9 Changed 7 years ago by gnw3

Cc: gnwiii@… added

Cc Me!

comment:10 Changed 7 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:11 Changed 7 years ago by eborisch (Eric A. Borisch)

Cc: eborisch@… added

Cc Me!

comment:12 Changed 7 years ago by someuser12

Cc: macosx12345@… added

Cc Me!

comment:13 Changed 7 years ago by mopihopi

The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue.

comment:14 Changed 7 years ago by wojdyr@…

Cc: wojdyr@… added

Cc Me!

comment:15 Changed 7 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Changed 7 years ago by cooljeanius (Eric Gallager)

patch from upstream bug report

comment:16 in reply to:  13 Changed 7 years ago by cooljeanius (Eric Gallager)

Replying to mopihopi@…:

The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue.

I re-attached it here for easier review. Could someone commit it please? (I am running into this issue, as well, which is preventing me from testing one of my other Portfiles that I am developing...)

comment:17 Changed 7 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Committed in r117639.

comment:18 in reply to:  17 Changed 7 years ago by cooljeanius (Eric Gallager)

Replying to raimue@…:

Committed in r117639.

Just confirming that that worked for me, thanks!

Note: See TracTickets for help on using tickets.