port for gpick

[rudloff@…]

Hello,

Here is a port for ​gpick.

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• You've used the cmake portgroup, which is used to indicate you want to use cmake for configuration instead of a configure script, but then used "use_configure no" which means no configuration phase will be run at all. Does this port actually use cmake? If not, remove the cmake portgroup. I don't think it does; I see no occurrences of the word "cmake" in the source code.
• Because you're using "use_configure no", you're responsible for manually UsingTheRightCompiler and -arch flags and adding a universal variant, if possible. This Sconscript appears to support setting CC, CXX, CFLAGS, CXXFLAGS and LDFLAGS in the build environment so that's probably the solution.
• The first revision of any given version of a port should be 0, not 1, and this can be accomplished by omitting the revision line entirely.
• The homepage you've listed doesn't mention gpick. Is ​http://code.google.com/p/gpick/ maybe a more appropriate homepage?
• The master_sites should just be "googlecode".
• The extract.suffix line should be removed since .tar.gz is the default.
• You've added scons as a library dependency but it's only a build dependency.
• The patch doesn't look right, but once the portfile sets build.env to include CFLAGS, CXXFLAGS and LDFLAGS to set the -arch flags, the patch won't be needed because the section of code it changes will no longer be reached.

I've made these changes locally but the port doesn't build with libc++ so I've filed an upstream bug report: ​https://code.google.com/p/gpick/issues/detail?id=110. Later I'll try to build it on an earlier version of OS X and if that builds then I'll commit it while we're waiting for a libc++ fix for Mavericks.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

• The patch doesn't look right, but once the portfile sets build.env to include CFLAGS, CXXFLAGS and LDFLAGS to set the -arch flags, the patch won't be needed because the section of code it changes will no longer be reached.

I've filed two additional issues for the situation you were correcting with the patch:

• -as-needed doesn't work with Apple's ld: ​https://code.google.com/p/gpick/issues/detail?id=111
• -lexpat is needed: ​https://code.google.com/p/gpick/issues/detail?id=112

[ryandesign (Ryan Carsten Schmidt)]

Added port in r114887.

[ryandesign (Ryan Carsten Schmidt)]

Buildbot build failures pointed out that pkgconfig and boost were required. I added these dependencies in r114888 and r114892 respectively. The build failure on Mavericks remains for the developers of gpick to resolve.