Port for Trimage

[rudloff@…]

Hello,

Here is a port for ​Trimage.

Regards,

[ryandesign (Ryan Carsten Schmidt)]

In the version field you claim this is 1.0.5 but in the fetch directives you have not restricted it to this version, so you'll actually get whatever the latest version is at install time. Instead, please fetch a specific revision so that builds are repeatable. Since this is hosted at github, use the github portgroup. Ideally you'd fetch from a tag, but unfortunately the developer hasn't tagged 1.0.5. Request that the developer to so. Until they do, you can list whatever specific git committish corresponds to version 1.0.5.

Is there a reason you've used python26 and not python27?

[rudloff@…]

I have sent an e-mail to the developpers about the tag. I have used python26 because Python 2.6 is listed as a requirement on ​http://trimage.org/.

[ryandesign (Ryan Carsten Schmidt)]

Replying to rudloff@…:

I have sent an e-mail to the developpers about the tag.

Great, thanks.

I have used python26 because Python 2.6 is listed as a requirement on ​http://trimage.org/.

But the requirements also include python-qt4 4.4 (we have 4.10.3), optipng 0.6.2.1 (we have 0.7.4), pngcrush 1.6.7 (we have 1.7.69), advancecomp 1.15 (we have 1.16), and jpegoptim 1.2.2 (we have 1.2.4). I assume these are minimum requirements and that somewhat later versions would be ok. We should use python27 if it will work because it is the most recent version of python27.

[rudloff@…]

It seems to work correctly with Python 2.7. I have updated the Portfile.

[rudloff@…]

Did you have a look at the new Portfile ? Can you tell me if I need to change something else ?

[mf2k (Frank Schima)]

This is not a complete Portfile review, but you need to change your depends_lib to depends_lib-append so you don't overwrite dependencies from the python and github portgroups.

[mf2k (Frank Schima)]

It is not valid to depend on the stub port py-pyqt4. It needs to be specifically py27-pyqt4.