#42048 closed enhancement (fixed)
apple-gcc42: simplify port
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | jeremyhu (Jeremy Huddleston Sequoia) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | haspatch | Cc: | |
| Port: | apple-gcc42 |
Description
This patch simplifies the apple-gcc42 port a bit. It still builds ok for me.
Attachments (1)
Change History (6)
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | apple-gcc42.diff added |
|---|
comment:1 follow-up: 4 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
That looks like an improvement to me, please push it.
The only thing I'm seeing as a possible concern is the removal of:
LIBRARY_PATH="/usr/lib" \ CPATH="/usr/include" \
I seem to recall there was a reason for those, but I can't remember. If it "works for you" I'm fine removing them. We can always revise it in the future if there was a valid reason for them.
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
MacPorts base automatically sets CPATH and LIBRARY_PATH to the values of configure.cpath and configure.library_path, respectively, in all phases. See proc command_exec in portutil.tcl.
comment:3 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Those are probably remnants of a bygone era then. Thanks.
comment:4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to jeremyhu@…:
That looks like an improvement to me, please push it.
I was also going to ask about:
# Needed for gfortran: #files/other_langs.patch: #+ --with-gmp=$DEST_ROOT \ #+ --with-mpfr=$DEST_ROOT \ #depends_lib port:gmp port:mpfr
Should that move into the non-bootstrap section too? It's commented out so it doesn't matter. Do you still have any plans for adding gfortran to this port? Seems unnecessary, since Apple GCC never shipped with that.
comment:5 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
I had plans for that a long time ago, but I don't any more. If someone wants to make a fortran compiler that understands multiple -arch arguments, it'd be more worthwhile to update the newer gcc ports to build the driver driver than spend time on gcc-apple-4.2. We can nuke that to save bits.
proposed patch