Opened 6 years ago

Closed 5 years ago

#42317 closed update (fixed)

fluxbox: update to 1.3.5

Reported by: ryandesign (Ryan Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc: nerdling (Jeremy L), cooljeanius (Eric Gallager), florian@…
Port: fluxbox

Description

This patch:

  • updates the port to 1.3.5
  • uses newer checksum types
  • removes the custom livecheck because the standard livecheck works fine
  • rewrites master_sites to avoid redirects
  • no longer runs autoreconf because that was added way back in 2008 in r43641 to fix Leopard build problems, and the configure script shipped in the current version was generated more recently than that, in 2013
  • indicates that the software is under the MIT license, per the homepage
  • adds imlib2 dependency because it is used if found

It builds fine for me on Mountain Lion. (It does not build on Mavericks, but neither does 1.3.1, and that's a separate problem for upstream to resolve.)

Attachments (3)

fluxbox-1.3.5.diff (1.3 KB) - added by ryandesign (Ryan Schmidt) 6 years ago.
proposed patch
Portfile.diff (361 bytes) - added by florian@… 5 years ago.
Portfile patch
patch-libcpp.diff (3.6 KB) - added by florian@… 5 years ago.
Patchfile fixes Mavericks compile error

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by ryandesign (Ryan Schmidt)

Attachment: fluxbox-1.3.5.diff added

proposed patch

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from pmq@… to macports-tickets@…

This port is no longer maintained.

comment:2 Changed 5 years ago by nerdling (Jeremy L)

Cc: snc@… added
Resolution: fixed
Status: newclosed

Updated in r121134.

comment:3 Changed 5 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: closedreopened

10.9 Build failure.

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/functional:1026:13: error: no matching constructor for initialization of 'binder2nd<std::__1::equal_to<WinClient *> >'
    {return binder2nd<__Operation>(__op, __x);}
            ^                      ~~~~~~~~~
fluxbox.cc:1362:25: note: in instantiation of function template specialization 'std::__1::bind2nd<std::__1::equal_to<WinClient *>, const WinClient *>' requested here
                Compose(bind2nd(equal_to<WinClient *>(), client),
                        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/functional:1012:5: note: candidate constructor not viable: 2nd argument ('const WinClient *const') would lose const qualifier
    binder2nd(const __Operation& __x, const typename __Operation::second_argument_type __y)
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/functional:1003:29: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class _LIBCPP_TYPE_VIS_ONLY binder2nd
                            ^

comment:4 Changed 5 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:5 Changed 5 years ago by florian@…

Cc: florian@… added

Cc Me!

Changed 5 years ago by florian@…

Attachment: Portfile.diff added

Portfile patch

Changed 5 years ago by florian@…

Attachment: patch-libcpp.diff added

Patchfile fixes Mavericks compile error

comment:6 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: reopenedclosed

Updated to 1.3.7 in r134553; 1.3.6 included a fix for the Mavericks build failure. In the future, let's keep separate issues in separate tickets. Per the ticket description, this ticket was meant to have dealt only with updating the port to 1.3.5, not the build failure on newer systems.

Note: See TracTickets for help on using tickets.