Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#42391 closed enhancement (fixed)

sleuthkit: patch for python bindings

Reported by: jul_bsd@… Owned by: jessekornblum@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: sleuthkit

Description

Attachments (2)

patch-Portfile-sleuthkit (495 bytes) - added by jul_bsd@… 6 years ago.
tsk4.1.3_external_type.patch (430 bytes) - added by jul_bsd@… 6 years ago.
patch (from previous link)

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by jul_bsd@…

Attachment: patch-Portfile-sleuthkit added

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to jessekornblum@…

Please actually attach your patchfile that you are linking to from google drive.

In the future, please Cc the port maintainers (port info --maintainers sleuthkit).

Changed 6 years ago by jul_bsd@…

patch (from previous link)

comment:2 Changed 6 years ago by jul_bsd@…

Cc: jul_bsd@… added

Cc Me! Sorry, but I don't see how you add a CC outside of yourself on trac.

Last edited 6 years ago by jul_bsd@… (previous) (diff)

comment:3 Changed 5 years ago by jul_bsd@…

any review? That's just a 2-lines header include but required for python bindings & plaso (and probably many other python security tools)

comment:4 Changed 5 years ago by mf2k (Frank Schima)

Cc: jul_bsd@… removed
Owner: changed from jessekornblum@… to macsforever2000@…

There is no need to Cc yourself since you are the reporter.

comment:5 Changed 5 years ago by mf2k (Frank Schima)

Keywords: haspatch added

comment:6 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from macsforever2000@… to jessekornblum@…

comment:7 Changed 5 years ago by jessekornblum@…

Looks good to me, but I don't have permissions to approve this patch.

comment:8 Changed 5 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Type: defectenhancement
Version: 2.2.1

Thanks. In the future, all patchfiles (including the Portfile patch itself) should be named like patch-foo.diff. I renamed the patchfile in the Portfile as such - namely patch-tsk4.1.3_external_type.diff. r119590.

comment:9 Changed 5 years ago by mf2k (Frank Schima)

This was added for #42392.

Last edited 5 years ago by mf2k (Frank Schima) (previous) (diff)

comment:10 Changed 5 years ago by jul_bsd@…

Thanks mf2k@

Note: See TracTickets for help on using tickets.