Opened 10 years ago

Closed 10 years ago

#42402 closed defect (fixed)

libdmapsharing: port fails to build with current version of libgee, update to version 0.9.24

Reported by: dbevans (David B. Evans) Owned by: mike@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc:
Port: libdmapsharing

Description

The current archived binary version of libdmapsharing still has a reference to libpng15 embedded. However, when I attempted to rebuild the port with the current libpng16, the port failed to build due to API changes in the current version of libgee @0.12.0. Build log excerpt follows.

vala-dmap-db.c:243:100: error: too few arguments to function call, expected 6, have 4
        _tmp0_ = gee_array_list_new (DMAP_TYPE_RECORD, (GBoxedCopyFunc) g_object_ref, g_object_unref, NULL);
                 ~~~~~~~~~~~~~~~~~~                                                                       ^
/opt/local/include/gee-0.8/gee.h:1499:1: note: 'gee_array_list_new' declared here
GeeArrayList* gee_array_list_new (GType g_type, GBoxedCopyFunc g_dup_func, GDestroyNotify g_destroy_func, GeeEqualDataFunc equal_func, void* equal_func_target, GDestroyNotify equal_func_target_destroy_notify);
^
7 warnings and 1 error generated.

Updating the port to version 0.9.24 solves the problem.

The attached patch

  • updates to latest version 0.9.24
  • updates dependencies as required
  • configuration updated to build with Apple dns_sd to avoid linking with avahi if it happens to be present.

I tried applying the current upstream patches for vala and gobject-introspection but they don't build for me as yet so not included here.

Let me know if this is OK to commit or your suggested changes otherwise.

Thanks

Attachments (1)

patch-libdmapsharing.diff (1.1 KB) - added by dbevans (David B. Evans) 10 years ago.
Proposed patch to update to version 0.9.24

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by dbevans (David B. Evans)

Attachment: patch-libdmapsharing.diff added

Proposed patch to update to version 0.9.24

comment:1 Changed 10 years ago by mike@…

I have not had any time lately to work on MacPorts, so I would be very happy if someone else could maintain this package. The patch looks fine, although I have not tested it.

comment:2 Changed 10 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Updated to version 0.9.24 in r116863, removing you as maintainer as requested. Builds successfully on all 4 buildbots 10.6-10.9 and initial cursory testing with grilo (via dmap plugin) shows no obvious errors. Will keep my eye on it for now but hopefully a full time maintainer with more expertise in this area will step up.

Note: See TracTickets for help on using tickets.