#42585 closed update (fixed)
py-saga @0.9.15_1: upgrade to py-saga @0.10
| Reported by: | petrrr | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | mojca (Mojca Miklavec) |
| Port: | py-saga |
Description
I provide a patch to update this port. The following additional changes are included:
- correction of livecheck, now only for the main port;
Attachments (2)
Change History (17)
Changed 10 years ago by petrrr
| Attachment: | patch-py-saga.diff added |
|---|
comment:2 Changed 10 years ago by mojca (Mojca Miklavec)
I looked at this ticket, but noticed that version 0.13 is already out (they've been very active releasing software in the last few days).
comment:3 Changed 10 years ago by petrrr
Yes, I noticed it. Actually, at least one version bump is due to some fixes to the release. I have not looked at the new version yet, but I can update and provide an upgraded patch soon. Not immediately, though.
comment:4 Changed 10 years ago by mojca (Mojca Miklavec)
What is your preference then?
- upgrade to 0.10 now
- wait until you prepare a patch for 0.13
- I try to change the version number and checksums and commit if that works
Changed 10 years ago by petrrr
| Attachment: | patch.py-saga.diff added |
|---|
patch for python/py-saga/Portfile
comment:7 Changed 10 years ago by petrrr
I provide an updated patch file, so that this port is updated directly to 0.13.
comment:8 Changed 10 years ago by mojca (Mojca Miklavec)
I suggest to wait for all the services to become functional again before committing. If I forget to commit by then, please remind me.
comment:9 Changed 10 years ago by petrrr
Fine, thanks! Was not aware there are still issues. I assume its now about the buildbots.
comment:11 Changed 10 years ago by mojca (Mojca Miklavec)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:13 Changed 10 years ago by petrrr
@mojca: Please note that r117925 does not correspond exactly to the provided patch. As a consequence the livecheck correction is not completely implemented.
comment:14 Changed 10 years ago by mojca (Mojca Miklavec)
I found it weird to put the livecheck on top when it's at the very end for all other ports. What I didn't notice is that it doesn't work as expected.
Does r117927 solve the issue? This is what the majority of other ports use.
comment:15 Changed 10 years ago by petrrr
Well, the conditional version is okay as well and I realize that most port authors prefer this for some reason. I assume it is copying only.
I did it the other way around intentionally as the one part is related to the mastersites and the other to the python portgroup and this kind of logic might end up in the related pieces eventually. But you cares ...
patch for python/py-saga/Portfile