Opened 5 years ago

Closed 5 years ago

#42599 closed submission (fixed)

new port: sysutil/pcsc-tools 1.4.22

Reported by: schmurtz_macport@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc:
Port: pcsc-tools

Description

Tools for accessing PC/SC driver, card or reader

(depend on p5-pcsc, ticket #42598)

Attachments (3)

files_patch-Makefile.zip (639 bytes) - added by schmurtz_macport@… 5 years ago.
patch-Makefile.diff (664 bytes) - added by schmurtz_macport@… 5 years ago.
(new)
Portfile (1.4 KB) - added by schmurtz_macport@… 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by schmurtz_macport@…

Attachment: files_patch-Makefile.zip added

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Thanks. Some observations:

  • "configure {}" should instead be written "use_configure no".
  • When you use "use_configure no", you're responsible for adding code to ensure you're UsingTheRightCompiler and -arch flags and adding a universal variant.
  • The dependency on "p5-pcsc" is improper. Don't depend on a stub port. Depend on the specific perl version of that port that you want. Usually, pick the version of perl that the perl5 port uses by default, so in this case, p5.16-pcsc. Alternately, offer variants for several supported perl versions.
  • The "license" field should indicate which version(s) of the GPL apply.
  • Unless it's enormous, in the future please just attach the patchfile, rather than zipping it first; that way, we can read it right here on the web without having to download and unzip it first.

comment:2 Changed 5 years ago by ryandesign (Ryan Schmidt)

Port: pcsc-tools added

Changed 5 years ago by schmurtz_macport@…

Attachment: patch-Makefile.diff added

(new)

Changed 5 years ago by schmurtz_macport@…

Attachment: Portfile added

comment:3 Changed 5 years ago by schmurtz_macport@…

Updated according to your comments.

comment:4 Changed 5 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Comitted in r117787 with the following changes:

  • Ensure MacPorts' CPPFLAGS, CFLAGS, CXXFLAGS and LDFLAGS are used
  • Simplify universal variant by using [get_canonical_archflags] (which requires the universal variant to be defined, that's why there's a variant universal {} line in there). At the same time, this ensures the correct architecture if a user configured a build arch different from the default and isn't building universal.
  • Removed the description of the universal variant, which is filled in automatically if missing.
Note: See TracTickets for help on using tickets.