Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#42653 closed update (fixed)

[update] py-construct to 2.5.1

Reported by: jul_bsd@… Owned by: software@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: macports@…
Port: py-construct

Description

  • update to 2.5.1
  • remove restriction to python 2.4, 2.5
  • dependency of Plaso (Ticket #42394)

Attachments (6)

patch-py_construct-Portfile (2.0 KB) - added by jul_bsd@… 10 years ago.
patch-py_construct-Portfile.diff (2.0 KB) - added by mf2k (Frank Schima) 10 years ago.
patch-py_construct-2.51-Portfile.diff (1.9 KB) - added by software@… 10 years ago.
Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile to update py-construct to 2.51
patch-py_construct-2.51-Portfile.2.diff (1.9 KB) - added by jul_bsd@… 10 years ago.
patch-py_construct-2.51-Portfile.3.diff (2.0 KB) - added by software@… 10 years ago.
Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile
patch-py-construct-Portfile.diff (2.8 KB) - added by jul_bsd@… 10 years ago.

Download all attachments as: .zip

Change History (20)

Changed 10 years ago by jul_bsd@…

Attachment: patch-py_construct-Portfile added

Changed 10 years ago by mf2k (Frank Schima)

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Cc: macports@… added; macfreek.nl:software dckd.nl:macports removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to software@…
Version: 2.2.1

Trac requires complete and non-obfuscated email addresses.

Please do not mix spacing adjustments and functional changes in the same patch.

comment:2 Changed 10 years ago by software@…

@jul_bsd: Thanks for the patch!

I've slightly modified the patch to:

  • add Python versions 3.1, 3.2, and 3.3 (http://construct.readthedocs.org/en/latest/ says it supports 2.5-3.3). I suspect 3.4 will work too.
  • Added py-six as dependency, since that is now required (I tested this with Python 2.7 and 3.3).
  • Ignore whitespace changes (I think they're fine, but apparently this is what macsforever2000 requested)
  • Removed my email from the maintainers list, as I'm no longer using py-construct at the moment.

@macsforever2000: What do you mean with "Trac requires complete and non-obfuscated email addresses."?

Changed 10 years ago by software@…

Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile to update py-construct to 2.51

comment:3 Changed 10 years ago by software@…

(on second thought, I added Python 3.4 as well, since it seems to work fine)

comment:4 in reply to:  2 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to software@…:

@macsforever2000: What do you mean with "Trac requires complete and non-obfuscated email addresses."?

He means that Trac requires normal “name@domain” email addresses, or else notification emails will not be delivered to the intended recipients. The obfuscated “domain:name” addresses used in Portfiles don’t work.

comment:5 Changed 10 years ago by jul_bsd@…

@macreek cool! Thanks for the update. miss a few things it seems.

comment:6 Changed 10 years ago by software@…

jul_bsd: could you test and report? If so, you or me can ask if this patch can be applied. (I don't have write access myself).

comment:7 Changed 10 years ago by jul_bsd@…

  • build/install ok
  • /opt/local/bin/python2.7 -c "import construct" is good (without path, it goes to Apple one)
  • 2.4 is Nok
$ port build subport=py24-construct
Warning: MacPorts running without privileges. You may be unable to complete certain actions (e.g. install).
--->  Computing dependencies for py24-construct
Error: Dependency 'py24-six' not found.
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port py-construct failed

and yes py-six Portfile is from 25 to 34.

comment:8 Changed 10 years ago by jul_bsd@…

any other questions pending?

for py-six, as official website says python 2.5+, I think we can probably remove 2.4 from py-construct too.

Changed 10 years ago by jul_bsd@…

comment:9 Changed 10 years ago by software@…

Agreed. http://construct.readthedocs.org/en/latest/ indeed mentions "Python 2.5-3.3".

A small correction: if we're dropping Py24 support, we can leave out the "subport py24-construct" bit.

See attachment.

Changed 10 years ago by software@…

Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile

comment:10 Changed 10 years ago by mf2k (Frank Schima)

Your patch does not actually apply for me:

$ patch Portfile patch-py_construct-2.51-Portfile.3.diff 
patching file Portfile
patch: **** malformed patch at line 34: -    # Python 2.4 (and it works fine with Python 2.5 too)

Also per lint, please determine and add the correct license:

$ port lint --nitpick py27-construct 
--->  Verifying Portfile for py27-construct
Warning: no license set
--->  0 errors and 1 warnings found.

comment:11 Changed 10 years ago by jul_bsd@…

  • port lint --nitpick
  • livecheck
  • /tab/spacex4/

Changed 10 years ago by jul_bsd@…

comment:12 Changed 10 years ago by jul_bsd@…

seems t has been fixed to 2.52 by stromnov@

http://trac.macports.org/log/trunk/dports/python/py-construct/Portfile?rev=119557

from what was said on this thread, still not fixed

  • remove support for 24
  • add support for 31 32
  • remove a maintainer software@…

comment:13 Changed 10 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Done in r120516. I also added py26.

comment:14 Changed 10 years ago by jul_bsd@…

Thanks mf2k@

Note: See TracTickets for help on using tickets.