Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#42780 closed defect (fixed)

dirvish @1.2.1_1: checksum mismatch, possible stealth update?

Reported by: cooljeanius (Eric Gallager) Owned by: chris@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc: ryandesign (Ryan Schmidt)
Port: dirvish

Description

It says this:

DEBUG: checksum phase started at Sun Mar  9 17:27:10 EDT 2014
--->  Verifying checksums for dirvish
DEBUG: Executing org.macports.checksum (dirvish)
--->  Checksumming dirvish-1.2.1.tgz
Error: Checksum (md5) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz md5 f3a127525dd2ef94bf79cd5614f6e147
Distfile checksum: dirvish-1.2.1.tgz md5 9035fdff055527882ea180c16c2f1bec
Error: Checksum (sha1) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz sha1 804a8ef09e47ac63499571db0c05fe2be9fd6b15
Distfile checksum: dirvish-1.2.1.tgz sha1 b79ec8e3d8a1efe11ea4e487dea2b46d1070f3ea
Error: Checksum (rmd160) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz rmd160 2942ca7bba1d4957ba66d88b341df605df7b2112
Distfile checksum: dirvish-1.2.1.tgz rmd160 7af67f7e04142da885a9ce3c5596e9960f192c39
The correct checksum line may be:
checksums           md5     9035fdff055527882ea180c16c2f1bec \
                    sha1    b79ec8e3d8a1efe11ea4e487dea2b46d1070f3ea \
                    rmd160  7af67f7e04142da885a9ce3c5596e9960f192c39

I tried checking with livecheck to see if there was a real update we could update to instead of dealing with this stealth update, but the livecheck seems broken:

Local-Admins-MacBook-Pro:dlcompat-20030629 ericgallager$ port -v livecheck dirvish
dirvish seems to have been updated (port version: 1.2.1, new version: 0.2p1.16)

(dirvish's homepage lists no such version)

Attachments (1)

dirvish-1.2.1-stealth-update.diff (2.0 KB) - added by ryandesign (Ryan Schmidt) 5 years ago.
proposed patch

Download all attachments as: .zip

Change History (7)

comment:1 in reply to:  description ; Changed 5 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added; chris@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to chris@…

Replying to egall@…:

It says this:

DEBUG: checksum phase started at Sun Mar  9 17:27:10 EDT 2014
--->  Verifying checksums for dirvish
DEBUG: Executing org.macports.checksum (dirvish)
--->  Checksumming dirvish-1.2.1.tgz
Error: Checksum (md5) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz md5 f3a127525dd2ef94bf79cd5614f6e147
Distfile checksum: dirvish-1.2.1.tgz md5 9035fdff055527882ea180c16c2f1bec
Error: Checksum (sha1) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz sha1 804a8ef09e47ac63499571db0c05fe2be9fd6b15
Distfile checksum: dirvish-1.2.1.tgz sha1 b79ec8e3d8a1efe11ea4e487dea2b46d1070f3ea
Error: Checksum (rmd160) mismatch for dirvish-1.2.1.tgz
Portfile checksum: dirvish-1.2.1.tgz rmd160 2942ca7bba1d4957ba66d88b341df605df7b2112
Distfile checksum: dirvish-1.2.1.tgz rmd160 7af67f7e04142da885a9ce3c5596e9960f192c39
The correct checksum line may be:
checksums           md5     9035fdff055527882ea180c16c2f1bec \
                    sha1    b79ec8e3d8a1efe11ea4e487dea2b46d1070f3ea \
                    rmd160  7af67f7e04142da885a9ce3c5596e9960f192c39

Yes, a stealth update has occurred. The difference between the old distfile available on distfiles.macports.org and the new one is that an enclosing directory now exists (so extract.mkdir yes is no longer needed in the Portfile), and this change was made to the dirvish.conf manpage:

--- dirvish.conf.5	2008-03-25 10:35:43.000000000 -0500
+++ dirvish.conf.5	2012-01-06 21:26:00.000000000 -0600
@@ -786,7 +786,7 @@
 .ta +.5i +36m
 	wd { sun }	+3 months
 	wd { sun } md { 1\-7 }	+1 year
-	wd { 1 } md { 1\-7 } mo { 1,4,7,10 }	never
+	wd { 1 } md { 1\-7 } mo { 1 4 7 10 }	never
 	hr { 10\-20 }	+10 days
 .ft R
 .fi

I tried checking with livecheck to see if there was a real update we could update to instead of dealing with this stealth update, but the livecheck seems broken:

Local-Admins-MacBook-Pro:dlcompat-20030629 ericgallager$ port -v livecheck dirvish
dirvish seems to have been updated (port version: 1.2.1, new version: 0.2p1.16)

(dirvish's homepage lists no such version)

1.2.1, from 2005, is the latest version. Presumably the software is dead and the livecheck could be disabled.

See patch, which also includes the fixes from #42782 and #42783, and adds the standard modeline. If you have no objections, I'd be happy to commit it for you.

Changed 5 years ago by ryandesign (Ryan Schmidt)

proposed patch

comment:2 in reply to:  1 ; Changed 5 years ago by cooljeanius (Eric Gallager)

Replying to ryandesign@…:

See patch, which also includes the fixes from #42782 and #42783, and adds the standard modeline. If you have no objections, I'd be happy to commit it for you.

Tried the patch, it worked (well except the modeline part failed to apply, but I was able to fix that manually), and dirvish installed successfully for me. I guess if we are fixing other issues besides the checksum here, the only thing that remains is the license:

Local-Admins-MacBook-Pro:~ ericgallager$ port -v lint --nitpick dirvish
--->  Verifying Portfile for dirvish
OK: Line 1 has emacs/vim Mode
OK: Line 2 has RCS tag ($Id$)
OK: Found PortSystem 1.0
OK: Found required variable: name
OK: Found required variable: version
OK: Found required variable: description
OK: Found required variable: long_description
OK: Found required variable: categories
OK: Found required variable: maintainers
OK: Found required variable: platforms
OK: Found required variable: homepage
OK: Found required variable: master_sites
OK: Found required variable: checksums
OK: Found required variable: license
OK: Found optional variable: epoch
OK: Found optional variable: revision
OK: Found platform: darwin
OK: Found platform: freebsd
OK: Found primary category: sysutils
OK: Found dependency: perl5.16
OK: Found dependency: p5.16-time-modules
OK: Found dependency: p5.16-timedate
OK: Found dependency: p5.16-time-period
OK: Found dependency: rsync
OK: Found dependency: bsdmake
Warning: no license set
OK: Portfile parent directory matches primary category
OK: Portfile directory matches port name
--->  0 errors and 1 warnings found.

According to the Dirvish FAQ, the license is "OSL", whatever that is: http://www.dirvish.org/FAQ.html#what_does_dirvish_cost_and_how_is_it_licensed
Looking through the list of licenses, "OSL" seems to be currently unrecognized by MacPorts...

Anyways, now just to hear back from the maintainer...

comment:3 in reply to:  2 ; Changed 5 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

According to the Dirvish FAQ, the license is "OSL", whatever that is

Probably the Open Software License.

comment:4 in reply to:  3 ; Changed 5 years ago by cooljeanius (Eric Gallager)

Replying to larryv@…:

Replying to egall@…:

According to the Dirvish FAQ, the license is "OSL", whatever that is

Probably the Open Software License.

OK, but what would we put for that for the license field in the Portfile?

comment:5 in reply to:  1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Replying to ryandesign@…:

Yes, a stealth update has occurred.

1.2.1, from 2005, is the latest version. Presumably the software is dead and the livecheck could be disabled.

See patch, which also includes the fixes from #42782 and #42783, and adds the standard modeline. If you have no objections, I'd be happy to commit it for you.

r122682

comment:6 in reply to:  4 Changed 5 years ago by ryandesign (Ryan Schmidt)

Replying to egall@…:

Replying to larryv@…:

Replying to egall@…:

According to the Dirvish FAQ, the license is "OSL", whatever that is

Probably the Open Software License.

OK, but what would we put for that for the license field in the Portfile?

I've set the license to "OSL-2" in r122683. I haven't reviewed the text of the license. If the license is permissive, we should add it to port_binary_distributable.tcl.

Note: See TracTickets for help on using tickets.