Opened 7 years ago

Closed 7 years ago

#42967 closed enhancement (fixed)

silo @4.9.1_0 Default to installing Fortran bindings if using Macports GCC

Reported by: johnsonsr@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: silo

Description

If the Silo installation is being built with a Macports GCC installation, which includes the Fortran compiler, there is no good reason not to install the Fortran bindings. (Since this is in the "science" grouping, it's also reasonable to expect some users to need the fortran bindings.)

I'm attaching a patch to add a +fortran variant and to enable +fortran by default if using +gcc45 through +gcc49.

Attachments (2)

silo.diff (816 bytes) - added by johnsonsr@… 7 years ago.
Patch file
Portfile-silo.diff (703 bytes) - added by johnsonsr@… 7 years ago.
Updated patch file reflecting discussion

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by johnsonsr@…

Attachment: silo.diff added

Patch file

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Port: silo added
Version: 2.2.1

Thanks. Per the guidelines, please instead attach your patch as a unified diff.

But why make this a variant. Is there a reason to not always install the FORTRAN bindings?

In the future, please fill in the Port field.

comment:2 Changed 7 years ago by johnsonsr@…

By default, because Apple doesn't distribute Fortran compilers, the Fortran bindings will not compile. (A working and link-compatible Fortran compiler is necessary.)

[Sorry about the improper submission. I noticed after I submitted but couldn't modify my ticket to fill out Port. I will be sure to next time.]

comment:3 Changed 7 years ago by mf2k (Frank Schima)

Right. But how about if we simply always install the FORTRAN bindings if a gcc4X variant is selected? Making a new variant that requires a gcc4X variant is confusing at best. What if someone tried to install the bindings without selecting a gcc4X variant?

comment:4 Changed 7 years ago by johnsonsr@…

Good point. I think your solution is better. Shall I submit a revised patch?

comment:5 Changed 7 years ago by mf2k (Frank Schima)

Please do!

Changed 7 years ago by johnsonsr@…

Attachment: Portfile-silo.diff added

Updated patch file reflecting discussion

comment:6 Changed 7 years ago by johnsonsr@…

Patch has been updated. Thanks!

comment:7 Changed 7 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Thanks. r118092. I used the completely undocumented configure.args-replace command instead and increased the revision so everyone gets this change.

Note: See TracTickets for help on using tickets.