Opened 5 years ago

Closed 5 years ago

#43518 closed enhancement (fixed)

pass @1.6.1_0 Missing bash-completion file

Reported by: hgonzale (Humberto Gonzalez) Owned by: john@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: cooljeanius (Eric Gallager)
Port: pass

Description

The upstream project offers a bash-completion script for this port (http://git.zx2c4.com/password-store/tree/src/completion), but it is neither included in pass @1.6.1_0, nor in bash-completion @2.1_8.

Attachments (2)

Portfile-patch.diff (680 bytes) - added by john@… 5 years ago.
Portfile-pass.diff (664 bytes) - added by john@… 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to john@…
Version: 2.2.1

In the future, please Cc the port maintainers (port info --maintainers pass).

Changed 5 years ago by john@…

Attachment: Portfile-patch.diff added

comment:2 Changed 5 years ago by john@…

Fixed by the attached patch.

comment:3 Changed 5 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:4 Changed 5 years ago by mf2k (Frank Schima)

$ port lint --nitpick 
--->  Verifying Portfile for pass
Warning: Variant bash does not have a description
Warning: Variant zsh does not have a description
Warning: Variant fish does not have a description
--->  0 errors and 3 warnings found.

Comments:

  • Add descriptions to the variants.
  • Delete the revision line because an update will not add the default variant anyway.
  • Should the variants conflict? If so, please add the appropriate conflicts arguments.

Changed 5 years ago by john@…

Attachment: Portfile-pass.diff added

comment:5 in reply to:  4 Changed 5 years ago by john@…

Replying to mf2k@…:

Comments:

  • Add descriptions to the variants.
  • Delete the revision line because an update will not add the default variant anyway.

Done.

  • Should the variants conflict? If so, please add the appropriate conflicts arguments.

No.

comment:6 Changed 5 years ago by mf2k (Frank Schima)

Keywords: haspatch maintainer added
Resolution: fixed
Status: newclosed

Sorry for the delay. r121158.

Note: See TracTickets for help on using tickets.