netpbm @10.66.02_1 Requesting a no_x11 variant

[mthomas+macports@…]

changeset:119542 makes netpbm require X11.

The only tool in the netpbm suite that requires X11 is pamx, the image viewer. Would you create a no_x11 variant for netpbm that does not build the viewer?

Sample patch file for the netpbm Porfile attached.

[su-v]

Cc Me!

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers netpbm).

We are not creating no_{foo} variants anymore. Rename the variant to x11 and make it do the reverse. See #39383. Furthermore, what if the user has the xorg-libX11 installed? The port must make sure it does not use it in that case.

[mthomas+macports@…]

Sorry, I was not aware that no_{foo} is no longer supported.

I have attached a second version of the Portfile patch that I hope addresses the issues. Getting netpbm not to build pamx when X11 is installed involves patching other/pamx/Makefile to check for a configuration variable that I have named MACPORTS_X11. The patch for the Makefile is patch-other-pamx-Makefile.diff, which is also attached.

[mthomas+macports@…]

Portfile patch version 2 that uses +x11 instead of no_x11

[Mathias.Laurin+macports.org@…]

Replying to mthomas+macports@…:

I have attached a second version of the Portfile patch that I hope addresses the issues. Getting netpbm not to build pamx when X11 is installed involves patching other/pamx/Makefile to check for a configuration variable that I have named MACPORTS_X11. The patch for the Makefile is patch-other-pamx-Makefile.diff, which is also attached.

Is it not enough to set X11LIB = NONE in ${configmk}?—That works for me but I do not have x11 installed. In any case, I believe that it should be set in any case. i.e.

@@ -84,6 +89,11 @@ TIFFLIB = -ltiff
 WANT_SSE = ${want_sse}
 ZLIB = -lz
 "
+    if {![variant_isset x11]} {
+        puts ${configmk} "
+X11LIB = NONE
+"
+    }
     close ${configmk}
 }

I would also like see your patch accepted by the way.

[Mathias.Laurin+macports.org@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Replying to Mathias.Laurin+macports.org@…:

Is it not enough to set X11LIB = NONE in ${configmk}?—That works for me but I do not have x11 installed.

Have a look in config.mk.in. X11_LIB = NONE is already in there, and no, that does not prevent X11 from being used if it is found by pkg-config.

[ryandesign (Ryan Carsten Schmidt)]

Replying to mthomas+macports@…:

I have attached a second version of the Portfile patch that I hope addresses the issues. Getting netpbm not to build pamx when X11 is installed involves patching other/pamx/Makefile to check for a configuration variable that I have named MACPORTS_X11. The patch for the Makefile is patch-other-pamx-Makefile.diff, which is also attached.

Thank you for the patch and sorry for the delay. I've committed it in r131363 with a few changes, including renaming the option to WANT_X11 (mirroring the existing option WANT_SSE).