Opened 8 years ago

Closed 8 years ago

#43805 closed enhancement (fixed)

zathura @0.2.7 buildt fails on SL

Reported by: harciga Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.0
Keywords: haspatch maintainer Cc: dbevans (David B. Evans)
Port: zathura

Description

Default compiler on SL fails to build the port #43794

Made a change so on SL and earlier macports-gcc-4.6 is used while disabling universal_variant. Unless somebody opens a ticket requesting +universal on those platforms I'll leave it at that.

Attachments (2)

Portfile-zathura.diff (618 bytes) - added by harciga 8 years ago.
Portfile-zathura.2.diff (540 bytes) - added by harciga 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by harciga

Attachment: Portfile-zathura.diff added

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch maintainer added

Thanks but that is not the solution we would usually want to use.

We would want to use "compiler.blacklist" to specify the compilers that do not work for this port.

If none of the compilers in "compiler.fallback" work, additional compilers that work can be added to that list.

There is no need to increase the port's revision if this only fixes a build failure (as opposed to a runtime failure, for which a revision increase is necessary).

Changed 8 years ago by harciga

Attachment: Portfile-zathura.2.diff added

comment:2 Changed 8 years ago by harciga

How about we just make sure to use a newer Xcode?

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

The version of Xcode is not tied to the version of the Xcode command line tools in all cases. Users can forget to update one or the other. On Snow Leopard, although they are tied together, Xcode 3.2.6, which is the latest free version and therefore the recommended version for Snow Leopard, uses gcc-4.2; Xcode 4.x for Snow Leopard is not free, and can only be obtained by paying Apple for a developer membership. compiler.blacklist is the correct solution for this issue.

comment:4 Changed 8 years ago by dbevans (David B. Evans)

Cc: devans@… added

Cc Me!

comment:5 Changed 8 years ago by dbevans (David B. Evans)

More specifically, adding something like this might work (I haven't tested it):

PortGroup       compiler_blacklist_versions 1.0

...

compiler.blacklist  gcc-4.0 gcc-4.2 llvm-gcc-4.2 {clang < 300}

comment:6 Changed 8 years ago by harciga

After reviewing https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/26560/steps/compile/logs/stdio/text

I think #43804 is enough to fix #43794. It's possible that zathura itself builds fine on SL.

Let's keep this ticket open until #43794 is closed.

comment:7 Changed 8 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

After resolving #43804, zathura builds successfully on SL.

Note: See TracTickets for help on using tickets.