Pythia : Version bump + respect C++ runtime settings

[cjones051073 (Chris Jones)]

Hi,

The attached diff updates Pythia to the latest version. It also fixes an issue where the port was not fully respecting the c++ runtime settings (for instance if the user was forcing the use of libc++, on pre-Mavericks systems).

cheers Chris

[mojca (Mojca Miklavec)]

Cc Me!

[cooljeanius (Eric Gallager)]

Cc Me!

[cjones051073 (Chris Jones)]

Ping ...

[mojca (Mojca Miklavec)]

Does the following work for you? (To avoid one extra "if"?)

build.args          CC=${configure.cc} \
                    CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}"

Just curious: why do you need configure.args-append as opposed to just configure.args?

Also: your patch doesn't apply cleanly here, but no need to upload a new one this time.

[cjones051073 (Chris Jones)]

Replying to mojca@…:

Does the following work for you? (To avoid one extra "if"?)

build.args          CC=${configure.cc} \
                    CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}"

I already tried that, and various permutations on the same theme. The bottom line is the pythia makefile is pretty funky, and does support many things you would expect. The only way I was able to get it working was with my patch as provided, which forcibly adds the -stdlib setting to the CXX variable. This seems the only thing the makefile really respects...

Just curious: why do you need configure.args-append as opposed to just configure.args?

To not override any settings coming from elsewhere. To put the question back, why not use append ?

Chris

Also: your patch doesn't apply cleanly here, but no need to upload a new one this time.

[cjones051073 (Chris Jones)]

Also: your patch doesn't apply cleanly here, but no need to upload a new one this time.

No idea about that, it was based on the SVN head at the time I submitted it. Are you sure your local copy is up to date with SVN ?

[mojca (Mojca Miklavec)]

Replying to jonesc@…:

Replying to mojca@…:

Does the following work for you? (To avoid one extra "if"?)

build.args          CC=${configure.cc} \
                    CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}"

I already tried that, and various permutations on the same theme.

But how is your patch effectively different from my proposal (other than the fact that my proposal would also add -stdbil=libstdc++ even when that's the default)?

I don't understand when your patch would work and mine wouldn't.

The bottom line is the pythia makefile is pretty funky

Is there any chance to ask them to improve the situation a bit?

Just curious: why do you need configure.args-append as opposed to just configure.args?

To not override any settings coming from elsewhere. To put the question back, why not use append ?

I was curious whether the absence of -append actually broke anything for you.

I might be wrong, but I would say that append should be used only when there is a reason for it. (Or else change that in all ports.)

[cjones051073 (Chris Jones)]

Replying to mojca@…:

Replying to jonesc@…:

Replying to mojca@…:

Does the following work for you? (To avoid one extra "if"?)

build.args          CC=${configure.cc} \
                    CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}"

I already tried that, and various permutations on the same theme.

But how is your patch effectively different from my proposal (other than the fact that my proposal would also add -stdbil=libstdc++ even when that's the default)?

I don't understand when your patch would work and mine wouldn't.

They do different things. Look carefully at mine, I redefine the CXX env var. Yours does not.

The bottom line is the pythia makefile is pretty funky

Is there any chance to ask them to improve the situation a bit?

Highly unlikely. I am not enough of a pythia user to really have the energy to go down that route just now ...

Just curious: why do you need configure.args-append as opposed to just configure.args?

To not override any settings coming from elsewhere. To put the question back, why not use append ?

I was curious whether the absence of -append actually broke anything for you.

I might be wrong, but I would say that append should be used only when there is a reason for it. (Or else change that in all ports.)

OK

[cjones051073 (Chris Jones)]

Replying to jonesc@…:

Replying to mojca@…:

Replying to jonesc@…:

Replying to mojca@…:

Does the following work for you? (To avoid one extra "if"?)

build.args          CC=${configure.cc} \
                    CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}"

I already tried that, and various permutations on the same theme.

But how is your patch effectively different from my proposal (other than the fact that my proposal would also add -stdbil=libstdc++ even when that's the default)?

I don't understand when your patch would work and mine wouldn't.

They do different things. Look carefully at mine, I redefine the CXX env var. Yours does not.

Sorry... Not enough coffee this morning...

I just realised I had cut and pasted your proposal incorrectly.

yes, I do eventually agree, yours should do the same, as add -stdbil=libstdc++ as well. That should be fine...

Chris

[mojca (Mojca Miklavec)]

Committed in r121647 as maintainer timeout.

[mojca (Mojca Miklavec)]

Ah, OK, it seems that I did break something:

/usr/bin/g++-4.2 -stdlib=libstdc++ -O2 -ansi -pedantic -W -Wall -Wshadow -c -Iinclude src/FJcore.cc -o tmp/archive/FJcore.o
cc1plus: error: unrecognized command line option "-stdlib=libstdc++"

See:

• ​https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/27335

I need help to properly handle that.

[cjones051073 (Chris Jones)]

Replying to mojca@…:

Ah, OK, it seems that I did break something:

/usr/bin/g++-4.2 -stdlib=libstdc++ -O2 -ansi -pedantic -W -Wall -Wshadow -c -Iinclude src/FJcore.cc -o tmp/archive/FJcore.o
cc1plus: error: unrecognized command line option "-stdlib=libstdc++"

See:

• ​https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/27335

I need help to properly handle that.

Maybe my original if statement is not so bad after all ;)

[mojca (Mojca Miklavec)]

OK, I can fix that. But this means that we probably have a "deeper problem" somewhere anyway.

Just before I do another mistake: is there any difference between CXX="${configure.cxx} -stdlib=libc++" and CXX=${configure.cxx}" -stdlib=libc++"?

[cjones051073 (Chris Jones)]

Replying to mojca@…:

OK, I can fix that. But this means that we probably have a "deeper problem" somewhere anyway.

Just before I do another mistake: is there any difference between CXX="${configure.cxx} -stdlib=libc++" and CXX=${configure.cxx}" -stdlib=libc++"?

No idea... The second is the one I tested...

[mojca (Mojca Miklavec)]

I now committed r121649.