Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#45572 closed defect (fixed)

new fallback livecheck fails for ports that don't set master_sites

Reported by: ryandesign (Ryan Schmidt) Owned by: kurthindenburg (Kurt Hindenburg)
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: Cc:
Port:

Description

The new fallback livecheck fails for ports that don't set master_sites. For example:

$ port -d livecheck xping
DEBUG: Copying /Users/rschmidt/Library/Preferences/com.apple.dt.Xcode.plist to /opt/local/var/macports/home/Library/Preferences
DEBUG: Checking last run information.
DEBUG: Changing to port directory: /Users/rschmidt/macports/dports/x11/xping
DEBUG: OS darwin/14.0.0 (Mac OS X 10.10) arch i386
DEBUG: universal_variant is false, so not adding the default universal variant
DEBUG: Requested variant +universal is not provided by port xping.
DEBUG: Requested variant -atlas is not provided by port xping.
DEBUG: Requested variant +accelerate is not provided by port xping.
DEBUG: Requested variant +bash_completion is not provided by port xping.
DEBUG: Running callback portconfigure::add_automatic_compiler_dependencies
DEBUG: Finished running callback portconfigure::add_automatic_compiler_dependencies
DEBUG: Running callback portbuild::add_automatic_buildsystem_dependencies
DEBUG: Finished running callback portbuild::add_automatic_buildsystem_dependencies
DEBUG: Starting logging for xping
DEBUG: Executing org.macports.main (xping)
DEBUG: livecheck phase started at Wed Oct 22 17:45:54 CDT 2014
DEBUG: Executing org.macports.livecheck (xping)
DEBUG: Portfile modification date is Wed Sep 15 15:33:03 CDT 2010
DEBUG: Port (livecheck) version is 1.9
DEBUG: Loading the defaults from '/Users/rschmidt/macports/dports/_resources/port1.0/livecheck/fallback.tcl'
DEBUG: can't read "master_sites": no such variable
    while executing
"lindex ${master_sites} 0"
    invoked from within
"if {!$has_homepage || ${livecheck.url} eq ${homepage}} {
    set livecheck.url [lindex ${master_sites} 0]
}"
    (file "/Users/rschmidt/macports/dports/_resources/port1.0/livecheck/master-sites.tcl" line 11)
    invoked from within
"source [getdefaultportresourcepath "port1.0/livecheck"]/master-sites.tcl"
    (file "/Users/rschmidt/macports/dports/_resources/port1.0/livecheck/fallback.tcl" line 6)
    invoked from within
"source $defaults_file": result
Error: Failed to livecheck xping: The defaults could not be loaded from '/Users/rschmidt/macports/dports/_resources/port1.0/livecheck/fallback.tcl'.
DEBUG: Error code: NONE
DEBUG: Backtrace: The defaults could not be loaded from '/Users/rschmidt/macports/dports/_resources/port1.0/livecheck/fallback.tcl'.
    while executing
"$procedure $targetname"
Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_x11_xping/xping/main.log for details.
Error: Follow http://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port xping failed

livecheck.type none might be a reasonable default for ports that don't set master_sites.

Change History (5)

comment:1 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Yes I saw that - from the docs it says master_sites is a required token. I'll put in a check for it.

comment:2 in reply to:  1 Changed 5 years ago by larryv (Lawrence Velázquez)

Ports that store distfiles in their filespath instead of downloading them don’t need a master_sites.

comment:3 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Thanks - done in r127212 - let me know of any other concerns.

comment:4 Changed 5 years ago by ryandesign (Ryan Schmidt)

I'm now getting this error with xping:

$ port livecheck xping
Error: Failed to livecheck xping: can't read "livecheck.url": can't read "homepage": no such variable
Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_x11_xping/xping/main.log for details.
Error: Follow http://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port xping failed

The homepage variable is also "required", as was master_sites, but it would be nice if ports that don't set them didn't show errors.

comment:5 in reply to:  4 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Replying to ryandesign@…:

The homepage variable is also "required", as was master_sites, but it would be nice if ports that don't set them didn't show errors.

done r127215.

Note: See TracTickets for help on using tickets.