Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#46059 closed defect (fixed)

tclreadline @2.1.0_1 build failure with readline 6.3

Reported by: rpokala@… Owned by: DanielO (Daniel O'Connor)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc: ryandesign (Ryan Schmidt)
Port: tclreadline

Description

[host:~] root# port -d install tclreadline
    ...
--->  Building tclreadline
DEBUG: Executing org.macports.build (tclreadline)
DEBUG: Environment: 
CC_PRINT_OPTIONS='YES'
CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/.CC_PRINT_OPTIONS'
CPATH='/opt/local/include'
LIBRARY_PATH='/opt/local/lib'
MACOSX_DEPLOYMENT_TARGET='10.10'
DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0" && /usr/bin/make -j8 -w all'
DEBUG: Executing command line:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0" && /usr/bin/make -j8 -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0'
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-am
make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0'
/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/clang -DHAVE_CONFIG_H -I. -I/opt/local/include -I/usr/include/readline  -I/opt/local/include  -pipe -Os -arch x86_64 -MT tclreadline.lo -MD -MP -MF .deps/tclreadline.Tpo -c -o tclreadline.lo tclreadline.c
libtool: compile:  /usr/bin/clang -DHAVE_CONFIG_H -I. -I/opt/local/include -I/usr/include/readline -I/opt/local/include -pipe -Os -arch x86_64 -MT tclreadline.lo -MD -MP -MF .deps/tclreadline.Tpo -c tclreadline.c  -fno-common -DPIC -o .libs/tclreadline.o
tclreadline.c:422:6: warning: implicit declaration of function 'ding' is invalid in C99 [-Wimplicit-function-declaration]
            ding();
            ^
tclreadline.c:638:41: error: use of undeclared identifier 'CPPFunction'
    rl_attempted_completion_function = (CPPFunction *) TclReadlineCompletion;
                                        ^
tclreadline.c:638:54: error: expected expression
    rl_attempted_completion_function = (CPPFunction *) TclReadlineCompletion;
                                                     ^
tclreadline.c:748:12: warning: implicit declaration of function 'completion_matches' is invalid in C99 [-Wimplicit-function-declaration]
        matches = completion_matches(text, TclReadline0generator);
                  ^
tclreadline.c:748:10: warning: incompatible integer to pointer conversion assigning to 'char **' from 'int' [-Wint-conversion]
        matches = completion_matches(text, TclReadline0generator);
                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tclreadline.c:884:13: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion]
    *args = '\0';
            ^~~~
4 warnings and 2 errors generated.
make[1]: *** [tclreadline.lo] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_tclreadline/tclreadline/work/tclreadline-2.1.0" && /usr/bin/make -j8 -w all 
Exit code: 2
Error: org.macports.build for port tclreadline returned: command execution failed

Change History (6)

comment:1 Changed 4 years ago by mf2k (Frank Schima)

Cc: darius@… removed
Owner: changed from macports-tickets@… to darius@…

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Summary: tclreadline @2.1.0_1 build failure on Yosemitetclreadline @2.1.0_1 build failure with readline 6.3

This is not Yosemite-specific; it's because in readline 6.3 certain symbols were renamed. For example, CPPFunction was renamed to rl_completion_func_t.

comment:3 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

r134941 (maintainer timeout)

comment:4 Changed 4 years ago by rpokala@…

Thanks ryandesign! But, the change in question just handled the symbol renaming; what about the completion_matches() issue?

comment:5 Changed 4 years ago by ryandesign (Ryan Schmidt)

That's just a warning, not an error. Does it cause a problem for you?

comment:6 in reply to:  5 Changed 4 years ago by rpokala@…

Replying to ryandesign@…:

That's just a warning, not an error. Does it cause a problem for you?

Ah, right you are. No, no problem. Thanks again!

Note: See TracTickets for help on using tickets.