#46444 closed enhancement (worksforme)
p5-file-comments: check dependencies
| Reported by: | mojca (Mojca Miklavec) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | dbevans (David B. Evans) | |
| Port: | p5-file-comments |
Description
Dependencies need to be double-checked. With default dependencies one gets:
Can't locate File/Which.pm in @INC
etc. But I don't find the dependency on File/Which listed anywhere, so maybe that needs to be reported upstream. Or something else must be wrong.
Change History (6)
comment:1 Changed 9 years ago by mojca (Mojca Miklavec)
comment:2 Changed 9 years ago by dbevans (David B. Evans)
| Resolution: | → worksforme |
|---|---|
| Status: | new → closed |
Looks good to me. Archive::Tar and Pod::Parser which are mentioned as dependencies in META.yml and Makefile.PL are in core for perl5.16 and up.
comment:3 Changed 9 years ago by mojca (Mojca Miklavec)
But then my next question: where (if anywhere) is the dependency on port:p${perl5.major}-file-which mentioned? Shouldn't the dependency be mentioned somewhere in the description files? Or what am I missing?
comment:4 Changed 9 years ago by dbevans (David B. Evans)
Looks like it's not mentioned but it obviously is used in the tests at least. Since it's not declared its hard to say whether it is needed at run time as well. Probably worth pointing out to the author.
comment:5 Changed 9 years ago by mojca (Mojca Miklavec)
I sent an email. I don't know whether he'll respond, but the port seems a bit unmaintained to me (based on the last release date).
I committed the changes in r131173. But those need to be double-checked by someone else.