Opened 6 years ago

Closed 23 months ago

#46603 closed defect (fixed)

Netpbm 10.69.02 does not build on PPC Tiger (Mac OS X 10.4.11) because of a faulty Makefile

Reported by: ballapete (Peter Dyballa) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: tiger Cc:
Port: netpbm

Description

gnumake[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced/other/pamx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced/other/pamx/Makefile:13: Extraneous text after `else' directive
/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced/other/pamx/Makefile:22: *** only one `else' per conditional.  Stop.
gnumake[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced/other/pamx'
gnumake[1]: *** [pamx/all] Error 2
gnumake[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced/other'
gnumake: *** [other/all] Error 2
gnumake: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_graphics_netpbm/netpbm/work/advanced" && /usr/bin/gnumake -w messages=yes 
Exit code: 2

The lines mentioned are:

     12 ifeq ($(WANT_X11),N)
     13 else ifeq ($(shell pkg-config x11 --modversion --silence-errors),)
     14   # Pkg-config has never heard of X11, or doesn't even exist
     15 
     16   ifneq ($(X11LIB),NONE)
     17     HAVE_X11LIB = Y
     18     ifneq ($(X11HDR_DIR)x,x)
     19       EXTERN_INCLUDES += -I$(X11HDR_DIR)
     20     endif
     21   endif
     22 else
     23   HAVE_X11LIB = Y
     24   X11LIB = $(shell pkg-config x11 --libs)
     25   EXTERN_INCLUDES += $(shell pkg-config x11 --cflags)
     26 endif

Change History (5)

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… removed
Keywords: tiger added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Ah. This is from a patch I added recently (#43566). This works with make 3.81, but Tiger has make 3.80. Should be simple to revise the patch to be compatible with make 3.80.

comment:2 in reply to:  1 Changed 6 years ago by ballapete (Peter Dyballa)

Replying to ryandesign@…:

Ah. This is from a patch I added recently (#43566). This works with make 3.81, but Tiger has make 3.80. Should be simple to revise the patch to be compatible with make 3.80.

Adding in Portfile on line #68

MAKE = gmake

seems to be a fix for this issue.

comment:3 Changed 5 years ago by ryandesign (Ryan Schmidt)

Yes, using MacPorts gmake instead of Xcode's is a workaround. It should be possible to rewrite the Makefile patch so that this is not necessary, but I have not had time to do this. I'll add the gmake dependency until then. r133871

comment:4 Changed 4 years ago by ballapete (Peter Dyballa)

Since Netpbm 10.76 is out and installed and it uses gmake to build the port, this ticket can be closed now…

comment:5 Changed 23 months ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.