Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#47804 closed submission (fixed)

New port: trash

Reported by: xuchunyang (Chunyang Xu) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: Cc:
Port: trash


It's a small command-line program that move files to the trash.


Attachments (1)

Portfile (896 bytes) - added by xuchunyang (Chunyang Xu) 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by xuchunyang (Chunyang Xu)

Attachment: Portfile added

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned


And to think, I've just been using a trash shell script that does:

mv -i "$@" ~/.Trash/

This looks much more comprehensive and safer.

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r136584 with these changes:

  • added a Makefile patch to no longer hardcode -mmacosx-version-min=10.5 -arch i386 so as to support other architectures and maybe earlier OS X versions
  • because the port uses use_configure no, added args to use the right compiler and -arch flags and universal variant
  • changed mode of trash from 775 to 0755. We usually don't give write permission to the group. Also, though Tcl accepts modes specified with or without the leading octal-indicating 0, and there is no consensus across all of MacPorts on this, it is at least good to be consistent within a single portfile
  • added depends_build bin:pod2man:perl5 since pod2man is used in the Makefile
  • shortened description and lengthened long_description
  • added # $Id$ line
  • realigned whitespace so that indentations are at multiples of 4 characters, as the modeline claims

comment:3 in reply to:  2 Changed 4 years ago by xuchunyang (Chunyang Xu)

Thank you very much for the detailed explanation and the commit.

Note: See TracTickets for help on using tickets.