Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#47866 closed submission (fixed)

py27-molmod @1.1 New Port submission

Reported by: tczorro (Derrick) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: py-molmod

Description

molmod is a python package that is used by Zeobuilder and Tracks. And Tracks is a collection of molecular dynamics and monte carlo analysis scripts

MainPage for molmod: http://molmod.github.io/molmod/tutorial/install.html

Attachments (1)

Portfile (2.0 KB) - added by tczorro (Derrick) 9 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by mf2k (Frank Schima)

Keywords: Molmod removed
Port: py-molmod added; molmod removed
Summary: py27-molmod @1.1 NewPort submissionpy27-molmod @1.1 New Port submission
Version: 2.3.3

comment:2 Changed 9 years ago by mf2k (Frank Schima)

Is this really a python module? Or is it software that requires python? If the latter, then remove the python portgroup, call it molmod and depend on python27 and py27-numpy, etc.

comment:3 in reply to:  2 Changed 9 years ago by tczorro (Derrick)

Replying to mf2k@…:

Is this really a python module? Or is it software that requires python? If the latter, then remove the python portgroup, call it molmod and depend on python27 and py27-numpy, etc.

This is a python module.

comment:4 Changed 9 years ago by mf2k (Frank Schima)

OK. Then that is good.

Since you are downloading from github, it would be best to utilize the github portgroup which will greatly simplify fetching the source code.

Changed 9 years ago by tczorro (Derrick)

Attachment: Portfile added

comment:5 in reply to:  4 Changed 9 years ago by tczorro (Derrick)

Replying to mf2k@…:

OK. Then that is good.

Since you are downloading from github, it would be best to utilize the github portgroup which will greatly simplify fetching the source code.

Just updated my Portfile. Add github and relative settings.

comment:6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:7 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r136822 with these changes:

  • removed python.default_version 27 because that is the default
  • moved the github.setup line above the name line and removed the redundant version line
  • moved the compilers.setup line inside the subport conditional, so that the compiler variants don't get made available in the stub port where they don't belong
  • removed custom livecheck since the github portgroup's default works fine
  • corrected typos in descriptions
  • removed trailing whitespace

I am curious how you arrived at your selection of compiler variant exclusions. You've excluded gcc 4.5 through 4.9 inclusive, leaving gcc 4.4, 5, and 6 variants (and also the non-gcc variants).

comment:8 in reply to:  7 ; Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign@…:

I am curious how you arrived at your selection of compiler variant exclusions. You've excluded gcc 4.5 through 4.9 inclusive, leaving gcc 4.4, 5, and 6 variants (and also the non-gcc variants).

The more important question is why compiler variants are being offered at all, since the port builds file without them.

comment:9 in reply to:  8 ; Changed 9 years ago by tczorro (Derrick)

Replying to ryandesign@…:

Replying to ryandesign@…:

I am curious how you arrived at your selection of compiler variant exclusions. You've excluded gcc 4.5 through 4.9 inclusive, leaving gcc 4.4, 5, and 6 variants (and also the non-gcc variants).

The more important question is why compiler variants are being offered at all, since the port builds file without them.

On their website, the compiler is added into compilers.

comment:10 in reply to:  9 ; Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to yangx59@…:

On their website, the compiler is added into compilers.

I don't think I understand what you mean.

comment:11 in reply to:  10 Changed 9 years ago by tczorro (Derrick)

Replying to ryandesign@…:

Replying to yangx59@…:

On their website, the compiler is added into compilers.

I don't think I understand what you mean.

If not necessary, we could erase those setting about gcc. I mean on their website, gcc is recommended, especially gcc >=4.5 versions.

comment:12 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Then why did you exclude gcc 4.5 through 4.9 inclusive in your portfile?

And as I said, it builds fine with the default compiler, clang.

Recommendations to use gcc, made by projects that are not specifically considering OS X in that recommendation, should usually be ignored.

Since it sounds like there was some misunderstanding here, I removed the compiler variants in r136824.

comment:13 in reply to:  12 Changed 9 years ago by tczorro (Derrick)

Replying to ryandesign@…:

Then why did you exclude gcc 4.5 through 4.9 inclusive in your portfile?

And as I said, it builds fine with the default compiler, clang.

Recommendations to use gcc, made by projects that are not specifically considering OS X in that recommendation, should usually be ignored.

Since it sounds like there was some misunderstanding here, I removed the compiler variants in r136824.

If it still works, it's fine. Thank you.

Note: See TracTickets for help on using tickets.