Opened 4 years ago

Closed 4 years ago

#48128 closed update (fixed)

smartmontools: update to 6.4

Reported by: RJVB (René Bertin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: smartmontools

Description

Update for the smartmontools port, to upstream 6.4 and replacing obsolescent configure arguments to their new variants.

Attachments (1)

smartmontools.diff (2.3 KB) - added by RJVB (René Bertin) 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

Summary: update: smartmontoolssmartmontools: update to 6.4

configure.args-replace should be used where possible, instead of a configure.args-delete and configure.args-append pair.

What's going on with the # kate line between the modeline and the $Id$ line? I assume this line is used by a program installed by the kate port, and that you used that program to edit this portfile, but I'm not sure how thrilled I am with the idea of adding yet another line to the top of all portfiles (and I'm certainly not thrilled with the idea of different ports having different lines at the top). If we want to consider this # kate line, it should be agreed upon on the developer mailing list first.

comment:2 Changed 4 years ago by RJVB (René Bertin)

Indeed, what *is* going on with that modeline or its presence? Yes, I use KDevelop as an IDE for maintaining my port repo. Adding a kate modeline is the only way to be sure that the files are edited with the required settings. There's no need to add that modeline to all Portfiles of course, but the alternative to not adding it is taking the risk that I end up with files that don't have the same settings throughout. This has come up before, and since that time I haven't been able to figure out if it's even possible to merge the kate modeline with the existing modeline. It may be possible to move it to the end of the file, though.

Changed 4 years ago by RJVB (René Bertin)

Attachment: smartmontools.diff added

comment:3 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:4 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Thanks r139155 - I removed the kate modeline in this commit until there's consensus on adding another modeline.

Note: See TracTickets for help on using tickets.