Opened 9 years ago

Closed 8 years ago

#48522 closed enhancement (fixed)

ifeffit, p5-ifeffit, pgplot: add gcc5 variant

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: joefowler (Joe Fowler)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), dbevans (David B. Evans), mojca (Mojca Miklavec), dstrubbe (David Strubbe)
Port: ifeffit, p5-ifeffit, pgplot

Description

Can we add a gcc5 variant to ifeffit and make it the default? gcc5 is the latest stable version of gcc.

Change History (14)

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: mcalhoun@… added

Comments in the port say the same change would need to be made simultaneously in p5-ifeffit and pgplot.

comment:2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Port: p5-ifeffit pgplot added
Summary: ifeffit: add gcc5 variantifeffit, p5-ifeffit, pgplot: add gcc5 variant

comment:3 Changed 9 years ago by dbevans (David B. Evans)

Cc: devans@… added

Cc Me!

comment:4 in reply to:  1 ; Changed 9 years ago by dbevans (David B. Evans)

Replying to ryandesign@…:

Comments in the port say the same change would need to be made simultaneously in p5-ifeffit and pgplot.

Yes, they all need to be built and linked with the same compiler/libraries. In addition, the Makefile.PL used to build p5-ifeffit (which is compiler specific) is autogenerated during the build of ifeffit.

It would probably be a simplification to unify ifeffit and p5-ifeffit.

comment:5 in reply to:  4 ; Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to devans@…:

Yes, they all need to be built and linked with the same compiler/libraries.

Does it make a difference that all the stable MacPorts gcc ports already use the same libraries (from the libgcc port)?

comment:6 in reply to:  5 ; Changed 9 years ago by dbevans (David B. Evans)

Replying to ryandesign@…:

Replying to devans@…:

Yes, they all need to be built and linked with the same compiler/libraries.

Does it make a difference that all the stable MacPorts gcc ports already use the same libraries (from the libgcc port)?

That wasn't clear to me. Previously, p5-ifeffit was broken due to this type of mismatch with ifeffit and ifeffit didn't recognize plplot and silently built without it for similar reasons. I did what was necessary to make it work.

Doesn't seem to make much difference now anyway, since, according to its download page it's considered to be obsolete and hasn't been updated/maintained since 2008. The preferred replacement is Larch. Maybe we should port that.

Last edited 9 years ago by dbevans (David B. Evans) (previous) (diff)

comment:7 in reply to:  6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to devans@…:

Replying to ryandesign@…:

Replying to devans@…:

Yes, they all need to be built and linked with the same compiler/libraries.

Does it make a difference that all the stable MacPorts gcc ports already use the same libraries (from the libgcc port)?

That wasn't clear to me.

Yup, that was done two years ago in r109291; see #38814.

comment:8 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:9 Changed 8 years ago by mojca (Mojca Miklavec)

I committed r148587, but I'm not yet sure how to add a runtime dependency on gcc. I changed that because p5-ifeffit build was broken on the buildbot, but I would be grateful if someone could review it.

comment:10 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: dstrubbe@… added

r145996 added the variants to ifeffit.

comment:11 Changed 8 years ago by dstrubbe (David Strubbe)

Mojca, the runtime dependencies are automatic from the compilers portgroup.

comment:12 Changed 8 years ago by mojca (Mojca Miklavec)

Can you please check if I got other options right? Maybe some of the options are not needed.

If it looks ok, we can probably close the ticket, right?

I still don't fully grasp how the portgroup works, but are you saying that there is no way to tell the portgroup that no runtime dependencies are needed? I can imagine that there is one group of ports that needs a compiler to work (runtime) and another group of ports that only needs fortran to compile the sources and doesn't need a runtime dependency.

comment:13 Changed 8 years ago by dstrubbe (David Strubbe)

compilers.enforce_fortran can only be used on a port which is a dependency. I fixed this in r148774. Runtime dependencies are always needed corresponding to the compiler, as far as I know -- if you compile and link, the resulting executable needs libraries provided by the compiler.

comment:14 Changed 8 years ago by dstrubbe (David Strubbe)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.