Opened 9 years ago
Closed 9 years ago
#49266 closed enhancement (fixed)
R: use compiler portgroup to clean up variants
| Reported by: | seanfarley (Sean Farley) | Owned by: | kjellpk (Kjell Konis) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | R |
Description
This cleans up some duplicated code by using the compilers portgroup
Attachments (1)
Change History (6)
Changed 9 years ago by seanfarley (Sean Farley)
| Attachment: | patch-r-compilers.diff added |
|---|
comment:1 Changed 9 years ago by mf2k (Frank Schima)
| Port: | R added |
|---|---|
| Type: | defect → enhancement |
| Version: | 2.3.4 |
comment:2 follow-up: 3 Changed 9 years ago by kjellpk (Kjell Konis)
Maintainer here. I am happy with this change except that the default fortran compiler should be gfortran from gcc 4.8 (to match the official CRAN binary release). I wasn't able to find any documentation for compilers portgroup but my guess would be the compilers.setup line should be
compilers.setup require_fortran -gfortran -gcc48
Also, don't forget to bump the revision number.
comment:3 Changed 9 years ago by seanfarley (Sean Farley)
Replying to kjell.konis@…:
Maintainer here. I am happy with this change except that the default fortran compiler should be gfortran from gcc 4.8 (to match the official CRAN binary release). I wasn't able to find any documentation for compilers portgroup but my guess would be the compilers.setup line should be
compilers.setup require_fortran -gfortran -gcc48Also, don't forget to bump the revision number.
Ok, I'll fix that up. Thanks for the review!
comment:4 Changed 9 years ago by kjellpk (Kjell Konis)
This bug is duplicated in #49316. The patch there also makes 2 other useful fixes to the Portfile.
comment:5 Changed 9 years ago by dstrubbe (David Strubbe)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Please remember to fill in the Port field.