TeXShop3 @3.57: identical patch blocks for darwin 12, 13, 14

[ryandesign (Ryan Carsten Schmidt)]

I noticed that the TeXShop3 port has identical patch blocks for darwin 12, 13 and 14:

platform darwin 12 {
    patchfiles-append	patch-MyPDFKitView.m.diff patch-TSAppDelegate.m.diff \
	patch-MyPDFKitView-Magnification.m.diff
}

platform darwin 13 {
    patchfiles-append	patch-MyPDFKitView.m.diff patch-TSAppDelegate.m.diff \
	patch-MyPDFKitView-Magnification.m.diff
}

platform darwin 14 {
    patchfiles-append	patch-TSAppDelegate.m.diff \
	patch-MyPDFKitView-Magnification.m.diff
}

Why not make these a single block?

platform darwin {
    if {${os.major} >= 12 && ${os.major} <= 14} {
        patchfiles-append   patch-MyPDFKitView.m.diff \
                            patch-MyPDFKitView-Magnification.m.diff \
                            patch-TSAppDelegate.m.diff
    }
}

Even better would be if the patches were written in such a way that it will work correctly for any version of OS, and applied unconditionally. That's what would be required for the patch to be accepted by the upstream developers.

[jyrkiwahlstedt]

Good suggestion, thanks! However, it is probable that the developer makes the necessary changes in the next version. I've discussed this issue with him by email.

[ryandesign (Ryan Carsten Schmidt)]

Excellent, that would be the best.