Opened 9 years ago

Closed 8 years ago

#49484 closed enhancement (fixed)

mapserver: use variant requires instead of default_variants

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jeabraham
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: mapserver

Description

The mapserver port's variants use default_variants statements to indicate dependencies on other variants. This is nonstandard. The correct way to express dependencies among variants is to use the "requires" keyword in the variant statement, as in the attached patch. Does this look good to you? If so, I can commit.

Attachments (1)

mapserver-variant-dependencies.diff​ (1.7 KB) - added by ryandesign (Ryan Carsten Schmidt) 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: mapserver-variant-dependencies.diff​ added

comment:1 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:2 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: → fixed
Status: new → closed

done r144772

Note: See TracTickets for help on using tickets.