Opened 5 years ago

Closed 5 years ago

#49989 closed defect (fixed)

nedi: activation fails: /Library/LaunchDaemons/org.macports.nedisyslog.plist already exists and does not belong to a registered port

Reported by: ryandesign (Ryan Schmidt) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: Ionic (Mihai Moldovan), mojca (Mojca Miklavec), dbevans (David B. Evans)
Port: nedi

Description

Mojca and Mihai emailed that "/Library/LaunchDaemons/org.macports.nedisyslog.plist already exists and does not belong to a registered port".

The nedi port used to install this file incorrectly, bypassing the destroot. This was reported in #40700 and fixed in r128981, however a pre-activate phase was not added to the port to automatically clean up the results of the former incorrect behavior, thus leading to the activation problem now. Such a block should be added. The revision of the port needs to be increased when doing this.

Attachments (1)

nedi.diff (893 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by ryandesign (Ryan Schmidt)

Attachment: nedi.diff added

proposed patch

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

I haven't tested this patch yet.

comment:2 Changed 5 years ago by mojca (Mojca Miklavec)

Cc: devans@… added

Please also note that a new version is available (1.4), so the port could be upgraded at the same time as well in case someone is willing to test it. I committed r143393 to switch to perl 5.22 (#48365), but I didn't test the change as the port was a relatively complex one.

comment:3 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Committed with changes in r143403. My patch needed adjustment because it was testing for file existence, but the file that had been installed was a symlink, which would be broken; [file exists] will return false for a broken symlink. I adjusted it to use [file type] instead.

I don't know nedi or this portfile so I'm not updating the port to a new version right now. You can file a new ticket for that it you like.

Note: See TracTickets for help on using tickets.