Opened 8 years ago
Closed 8 years ago
#50120 closed enhancement (fixed)
py-htseq @0.6.1: add note about optional dependency matplotlib
| Reported by: | dliessi (Davide Liessi) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | kurthindenburg (Kurt Hindenburg) |
| Port: | py-htseq |
Description
Attachments (1)
Change History (6)
Changed 8 years ago by dliessi (Davide Liessi)
| Attachment: | Portfile-py-htseq.diff added |
|---|
comment:1 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Cc: | khindenburg@… added |
|---|
comment:2 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
Perhaps a better way would be to add a variant like +matplotlib which would add the dependency to it.
Also if htseq-qa doesn't work w/o matplotlib then that should be only installed if above variant is used.
comment:3 Changed 8 years ago by dliessi (Davide Liessi)
Matplotlib is an optional runtime dependency: the installed files are the same regardless of whether matplotlib is installed or not, and htseq-qa correctly warns the user if it cannot find matplotlib.
I'm still more inclined towards letting the user install py-matplotlib if it is actually needed, but I'd rather add matplotlib as a mandatory runtime dependency (even though it has a lot of dependencies) instead of defining a variant.
Other opinions?
comment:4 Changed 8 years ago by g5pw (Aljaž Srebrnič)
I'm with davide on this one, I think adding a note and letting the user install matplotlib if they want more functionality is better.
comment:5 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
OK, looks like I accidently committed this a few weeks ago in r144115 - we'll leave it as Davide has it.
Cc Me!