Opened 8 years ago

Closed 8 years ago

#50400 closed defect (fixed)

git @2.7.0_1: gitk fails to run due to unknown color "lime"

Reported by: raimue (Rainer Müller) Owned by: ci42
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc:
Port: git

Description

gitk fails to run with Tcl/Tk provided by OS X: 

$ /usr/bin/wish /opt/local/bin/gitk
Error in startup script: unknown color name "lime"
    (processing "-fore" option)
    invoked from within
"$ctext tag conf m2 -fore [lindex $mergecolors 2]"
    (procedure "makewindow" line 347)
    invoked from within
"makewindow"
    (file "/opt/local/bin/gitk" line 12434)

The color name was introduced before for X11 and Win32, but apparently not for OS X. Although gitk also works with tk @8.6 installed from MacPorts.

Adding a hard dependency on tcl and tk just for this simple change does not sound reasonable. I am attaching a patch as an immediate fix, but the issue should probably also be taken upstream.

Attachments (1)

git-color-lime.diff​ (3.6 KB) - added by raimue (Rainer Müller) 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by raimue (Rainer Müller)

Attachment: git-color-lime.diff​ added

comment:1 Changed 8 years ago by ci42

Resolution: → fixed
Status: new → closed

Thanks for the patch. Fixed in r145492.

Note: See TracTickets for help on using tickets.