#51348 closed update (fixed)
bash-completion @2.1: update to 2.3
| Reported by: | xeron (Ivan Larionov) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | bash-completion |
Description
bash-completion project has been moved to https://github.com/scop/bash-completion
There's a new version 2.3.
Patch attached.
Attachments (1)
Change History (5)
Changed 8 years ago by xeron (Ivan Larionov)
| Attachment: | bash-completion.patch added |
|---|
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | raimue@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to raimue@… |
| Version: | 2.3.4 |
comment:2 follow-up: 3 Changed 8 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 follow-up: 4 Changed 8 years ago by xeron (Ivan Larionov)
Thank you!
I'm ok with all you changes, but adding some comments just FYI:
- No need to increase the epoch, the version numbering scheme did not change
For some reason port -u upgrade outdated didn't update it for me until I bumped epoch.
- Release tarballs are preferred over tarballs generated by GitHub
If release tarballs are preferred why don't we set github.tarball_from releases by default? I actually didn't know about github.tarball_from parameter and it wasn't working w/o v after version so I just put it there :)
- Retain bash-completion-devel for the time being until it is properly marked as replaced_by and then removed
We should probably do this since bash-completion-devel is somehow useless right now.
comment:4 Changed 8 years ago by raimue (Rainer Müller)
Replying to xeron.oskom@…:
- Release tarballs are preferred over tarballs generated by GitHub
If release tarballs are preferred why don't we set
github.tarball_from releasesby default? I actually didn't know aboutgithub.tarball_fromparameter and it wasn't working w/ovafter version so I just put it there :)
Release tarballs are attached manually to a release (usually what make dist produces for automake-based build systems). Not all projects release such tarballs, so the default is what works for every project. The default for the github port group fetches a tarball that is generated by GitHub from version control, which does not include the configure scripts, automake helpers, m4 macros, etc.
- Retain bash-completion-devel for the time being until it is properly marked as replaced_by and then removed
We should probably do this since
bash-completion-develis somehow useless right now.
Agreed, I will look into that.
Thank you for the patch, very good work with all the patch files! I was not aware of the move and also the livecheck did not pick it up as the original website is still online (and only redirects with JavaScript).
Some comments and changes I applied:
Committed with these changes in r148553.