Changes between Initial Version and Version 1 of Ticket #51645


Ignore:
Timestamp:
Jun 16, 2016, 5:34:06 PM (8 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Agreed, the patch should not clobber the current version and compatibility version. The purpose of the patch was originally to add the install name, since upstream did not set it. Now that upstream does set install name and compatibility version and current version, that might no longer need to be patched. Once that's fixed, cfitsio's revision will need to be increased since this fix will change the installed files.

Regarding other binaries linked with cfitsio's libraries needing a recompile: those ports should have their revisions increased after the above is fixed.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51645

    • Property Owner changed from macports-tickets@… to Deil.Christoph@…

  • Ticket #51645 – Description

    initial v1  
    1 The patch-configure.diff patch is clobbering the original code in the configure script that sets the compatibility and current version of the dylib library using the -compatibility_version -current_version flags (https://trac.macports.org/browser/trunk/dports/science/cfitsio/files/patch-configure.diff?rev=148197).
     1The patch-configure.diff patch is clobbering the original code in the configure script that sets the compatibility and current version of the dylib library using the -compatibility_version -current_version flags (browser:trunk/dports/science/cfitsio/files/patch-configure.diff?rev=148197).
    22This appears to produce 3.390 shared libraries that look to MacPorts like they are compatible with 3.340. But this is not the case. On Linux systems the 3.390 shared libraries have different sonames compared to the 3.340 libraries.
    33The net result is that binaries delivered with MacPorts that depend on cfitsio, are not being recompiled after an upgrade to a cfitsio version that has a different soname.