gnome-sudoku build error on OSX 10.5.8 intel (i386)

[arboz@…]

This is very small and easy to fix.

Error occurs while compiling lib/qqwing-wrapper.cpp

Probably if using later std lib there will be no issue

qqwing-wrapper.cpp: In function ‘int* qqwing_generate_puzzle(int)’:
qqwing-wrapper.cpp:50: error: ‘nullptr’ was not declared in this scope
make[1]: *** [libsudoku_la-qqwing-wrapper.lo] Error 1

nullptr is not defined, however NULL is a macro which returns a null ptr

so line 50 needs to change to:

50c50
<         srand(time(nullptr));
---
>         srand(time(NULL));

example diff file attached

[arboz@…]

change nullptr to NULL

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers gnome-sudoku), if any. ​Per the guidelines, please instead attach the patchfile as a unified diff.

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers gnome-sudoku), if any. ​Per the guidelines, please instead attach the patchfile as a unified diff.

[dbevans (David B. Evans)]

This problem was the result of a conscious decision upstream to start using C++11 language features (such as nullptr) in this application. The effect for us was to break the build on OS X versions which use libstdc++ by default (10.8 and earlier). The build was successful for 10.9+ where libc++ is the default.

Due to many reports of breakage with older compilers similar to this one, version 3.20.4 has been released which backs out this change for the duration of the 3.20 stable release branch.

Note, however, that the move to C++11 is continuing in upstream master (and elsewhere in GNOME) so we can probably expect to see this issue revisited with the 3.22 stable release. If you're not willing or not able to upgrade to a later version of OS X (10.9+) you might want to look at LibcxxOnOlderSystems for ideas on how to work around this issue on older systems.

Fixed (temporarily) by the upgrade to gnome-sudoku 3.20.4 in r150284. Builds on 10.6+ and hopefully 10.5 as well.