ansible @2.1.0.0.1 new upstream version 2.1.1.0-1 is available

[lpancescu (Laurențiu Păncescu)]

Could you please upgrade the Ansible port to 2.1.1.0-1? It fixes a bug preventing the synchronize module from working properly when using it with Vagrant boxes (​https://github.com/ansible/ansible/issues/16284).

Thanks!

[adfernandes (Andrew Fernandes)]

Okay - working on it. A bit of testing and patching is needed since there's a non-ASCII test that fails:

DEBUG: euid/egid changed to: 0/0
DEBUG: chowned /opt/local/var/macports/build/_Users_andrew_Local_dports_sysutils_ansible/ansible/work/ansible-2.1.1.0-1/test/integration/roles/test_unarchive/files/foo.txt to macports
DEBUG: euid/egid changed to: 502/20
DEBUG: euid/egid changed to: 0/0
DEBUG: setting attributes on /opt/local/var/macports/build/_Users_andrew_Local_dports_sysutils_ansible/ansible/work/ansible-2.1.1.0-1/test/integration/roles/test_unarchive/files/foo.txt
DEBUG: euid/egid changed to: 502/20
--->  Patching test-unarchive-nonascii-àâæçéèïîôœ.tar.gz: s#/etc/ansible#/opt/local/etc/ansible#g
DEBUG: Executing reinplace: /usr/bin/sed s#/etc/ansible#/opt/local/etc/ansible#g < /opt/local/var/macports/build/_Users_andrew_Local_dports_sysutils_ansible/ansible/work/ansible-2.1.1.0-1/test/integration/roles/test_unarchive/files/test-unarchive-nonascii-àâæçéèïîôœ.tar.gz >@ file10 2>@stderr
sed: RE error: illegal byte sequence
DEBUG: child process exited abnormally
    while executing
"exec /usr/bin/sed s#/etc/ansible#/opt/local/etc/ansible#g < /opt/local/var/macports/build/_Users_andrew_Local_dports_sysutils_ansible/ansible/work/ans..."
    ("eval" body line 1)
    invoked from within
"eval exec $cmdline"
Error: reinplace: child process exited abnormally
Error: org.macports.patch for port ansible returned: reinplace sed(1) failed
DEBUG: Error code: NONE
DEBUG: Backtrace: reinplace sed(1) failed
    while executing
"proc-org.macports.patch-patch-0 org.macports.patch"
    ("eval" body line 1)
    invoked from within
"eval $procedure $targetname"
Warning: targets not executed for ansible: org.macports.activate org.macports.patch org.macports.configure org.macports.build org.macports.destroot org.macports.install

It will take a day or so for me to get around to it, though!

[lpancescu (Laurențiu Păncescu)]

Thanks, I appreciate the effort!

Is that code trying to use /usr/bin/sed to patch a binary archive? Apple's sed defaults to expecting UTF-8 - I assume it tries to read the binary data as an UTF-8 stream, and it fails decoding it. If that's the case, sed should probably be forced to treat the input stream as binary data; I assume invoking it as 'LANG=C LC_ALL=C sed' should be enough, but I haven't tested it.

[larryv (Lawrence Velázquez)]

That’s an unorthodox file to be patching, to say the least. You can try tweaking the patch phase:

dports/sysutils/ansible/Portfile

@@ -50 +50 @@
 patch {
     fs-traverse f ${worksrcpath} {
         if {[file isfile ${f}] && ![regexp {\.(ico|png|eot|ttf|woff|reg)$} ${f} match] && ![regexp {\.git} ${f} match] && ![regexp {v2/test/test.yml} ${f} match]} {
-            reinplace "s#/etc/ansible#${prefix}/etc/ansible#g" ${f}
-            reinplace "s#/usr/share/ansible#${prefix}/share/ansible#g" ${f}
+            reinplace -locale C "s#/etc/ansible#${prefix}/etc/ansible#g" ${f}
+            reinplace -locale C "s#/usr/share/ansible#${prefix}/share/ansible#g" ${f}
         }
     }
 }

[adfernandes (Andrew Fernandes)]

Yes, I can't recall why all the reinplace stuff... but I didn't like forcing the locale because upstream is pretty good about keeping up UTF-8 support.

Turns out the solution is just to add .gz to one of the ignored file extensions.

Fixed in r151238