aria2 @1.24.0 Snow Leopard build error related to AppleTLSContext.cc; and fix

[kenneth.f.cunningham@…]

Aria2 @1.24 build fails on Snow Leopard due to AppleTLSContext errors. I see a previous bug report for an earlier version of aria2 regarding this same issue <​https://trac.macports.org/ticket/39100>.

Here is the error:

AppleTLSContext.cc:294:10: error: no matching function for call to 'SecIdentitySearchCopyNext'
  while (SecIdentitySearchCopyNext(search, &id) == errSecSuccess) {

A little surgery on the function seemed to get the build to proceed:

change to
  while (SecIdentitySearchCopyNext((SecIdentitySearchRef)&raw_search, &id) == errSecSuccess) {

but then failed during link:

Undefined symbols for architecture x86_64:
  "_kSecImportExportPassphrase", referenced from:
      aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*) in libaria2.a(AppleTLSContext.o)
  "_kSecImportItemIdentity", referenced from:
      aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*) in libaria2.a(AppleTLSContext.o)
ld: symbol(s) not found for architecture x86_64

So ultimately disabled apple-tls on Snow Leopard, and build succeeds. Diff attached. Note - aria2 requires c++11, and so the <​https://trac.macports.org/wiki/LibcxxOnOlderSystems> modification for Snow Leopard is presumably required. I didn't try it without the libcxx modification.

[kenneth.f.cunningham@…]

patch to disable apple-tls on Snow Leopard