Opened 8 years ago
Closed 6 years ago
#52384 closed defect (fixed)
hexchat: uses installed headers opportunistically
| Reported by: | Ionic (Mihai Moldovan) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | hexchat |
Description (last modified by Ionic (Mihai Moldovan))
hexchat uses the already installed system headers, if possible.
Trace mode helps in such cases, but let's fix this opportunistic usage anyway.
This patch should be applied before #52385.
Just for review, if you're okay with it I can apply it myself.
Attachments (1)
Change History (8)
Changed 8 years ago by Ionic (Mihai Moldovan)
| Attachment: | hexchat-no-system-hexchat-includes.patch added |
|---|
comment:1 Changed 8 years ago by Ionic (Mihai Moldovan)
| Description: | modified (diff) |
|---|
comment:2 Changed 8 years ago by larryv (Lawrence Velázquez)
comment:3 Changed 8 years ago by raimue (Rainer Müller)
| Status: | new → assigned |
|---|
This can just be fixed in hexchat build system by reordering the include arguments.
Pull request submitted upstream: https://github.com/hexchat/hexchat/pull/1822
comment:4 Changed 8 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed in r153195.
comment:5 Changed 6 years ago by Ionic (Mihai Moldovan)
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening, since it's back with the meson build system.
Haven't seen problems caused by this yet, but let's be aware of it.
comment:6 Changed 6 years ago by raimue (Rainer Müller)
Thanks for noticing!
I submitted a pull request to upstream to fix it: https://github.com/hexchat/hexchat/pull/2155
comment:7 Changed 6 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
Unless this is actually causing build problems, I’m not sure there’s a good reason to do this. Broader discussion at #40656.