Opened 8 years ago

Last modified 8 years ago

#52446 closed defect

Buildbot failure emails go to too many recipients — at Version 1

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: macports-tickets@…
Priority: High Milestone:
Component: contrib Version:
Keywords: Cc: mojca@…, jmr@…, cal@…, raimue@…
Port:

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Each buildbot failure email is sent not only to the maintainers of the ports affected by this build failure, but also to the recipients of all previous build failure emails.

I've looked at the code for a long time and don't understand it. Obviously the list of interested users isn't being cleared at the beginning of each build. But I don't see where in the code anything gets added to the list of interested users. I see that we have a custom PortsMailNotifier class that inherits from MailNotifier, which is "same as original, but calls portMessageFormatter with access to interested_users". But I don't see where portWatcherMessageFormatter ever makes use of the interested_users argument its been passed.

Change History (1)

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Priority: NormalHigh
Note: See TracTickets for help on using tickets.